refactor: consistent migration tests organization (#19635)

This commit is contained in:
Jesse Yang 2022-04-09 07:50:52 -07:00 committed by GitHub
parent ce2bd98442
commit b45f89b954
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 15 deletions

View File

@ -21,11 +21,8 @@ from superset.migrations.versions.fb13d49b72f9_better_filters import (
upgrade_slice, upgrade_slice,
) )
from .base_tests import SupersetTestCase
def test_upgrade_slice():
class TestMigration(SupersetTestCase):
def test_upgrade_slice(self):
slc = Slice( slc = Slice(
slice_name="FOO", slice_name="FOO",
viz_type="filter_box", viz_type="filter_box",
@ -33,8 +30,8 @@ class TestMigration(SupersetTestCase):
) )
upgrade_slice(slc) upgrade_slice(slc)
params = json.loads(slc.params) params = json.loads(slc.params)
self.assertNotIn("metric", params) assert "metric" not in params
self.assertIn("filter_configs", params) assert "filter_configs" in params
cfg = params["filter_configs"][0] cfg = params["filter_configs"][0]
self.assertEqual(cfg.get("metric"), "foo") assert cfg.get("metric") == "foo"