pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: Allows reload on default filter value error (#23459)

This commit is contained in:
Michael S. Molina 2023-03-23 08:24:54 -03:00 committed by GitHub
parent 212b7330d6
commit b0773145d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View File

@ -1214,39 +1214,41 @@ const FiltersConfigForm = (
}, },
]} ]}
> >
{error ? ( {error || showDefaultValue ? (
<BasicErrorAlert
title={t('Cannot load filter')}
body={error}
level="error"
/>
) : showDefaultValue ? (
<DefaultValueContainer> <DefaultValueContainer>
<DefaultValue {error ? (
setDataMask={dataMask => { <BasicErrorAlert
if ( title={t('Cannot load filter')}
!isEqual( body={error}
initialDefaultValue?.filterState?.value, level="error"
dataMask?.filterState?.value, />
) ) : (
) { <DefaultValue
formChanged(); setDataMask={dataMask => {
} if (
setNativeFilterFieldValues(form, filterId, { !isEqual(
defaultDataMask: dataMask, initialDefaultValue?.filterState?.value,
}); dataMask?.filterState?.value,
form.validateFields([ )
['filters', filterId, 'defaultDataMask'], ) {
]); formChanged();
forceUpdate(); }
}} setNativeFilterFieldValues(form, filterId, {
hasDefaultValue={hasDefaultValue} defaultDataMask: dataMask,
filterId={filterId} });
hasDataset={hasDataset} form.validateFields([
form={form} ['filters', filterId, 'defaultDataMask'],
formData={newFormData} ]);
enableNoResults={enableNoResults} forceUpdate();
/> }}
hasDefaultValue={hasDefaultValue}
filterId={filterId}
hasDataset={hasDataset}
form={form}
formData={newFormData}
enableNoResults={enableNoResults}
/>
)}
{hasDataset && datasetId && ( {hasDataset && datasetId && (
<Tooltip title={t('Refresh the default values')}> <Tooltip title={t('Refresh the default values')}>
<RefreshIcon onClick={() => refreshHandler(true)} /> <RefreshIcon onClick={() => refreshHandler(true)} />