pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: Allows reload on default filter value error (#23459)

This commit is contained in:
Michael S. Molina 2023-03-23 08:24:54 -03:00 committed by GitHub
parent 212b7330d6
commit b0773145d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View File

@ -1214,14 +1214,15 @@ const FiltersConfigForm = (
}, },
]} ]}
> >
{error || showDefaultValue ? (
<DefaultValueContainer>
{error ? ( {error ? (
<BasicErrorAlert <BasicErrorAlert
title={t('Cannot load filter')} title={t('Cannot load filter')}
body={error} body={error}
level="error" level="error"
/> />
) : showDefaultValue ? ( ) : (
<DefaultValueContainer>
<DefaultValue <DefaultValue
setDataMask={dataMask => { setDataMask={dataMask => {
if ( if (
@ -1247,6 +1248,7 @@ const FiltersConfigForm = (
formData={newFormData} formData={newFormData}
enableNoResults={enableNoResults} enableNoResults={enableNoResults}
/> />
)}
{hasDataset && datasetId && ( {hasDataset && datasetId && (
<Tooltip title={t('Refresh the default values')}> <Tooltip title={t('Refresh the default values')}>
<RefreshIcon onClick={() => refreshHandler(true)} /> <RefreshIcon onClick={() => refreshHandler(true)} />