pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 22:07:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(tag): update state to clear form on success (#25934)

Browse Source
This commit is contained in:
Hugh A. Miles II 2023-11-15 18:05:18 -05:00 committed by GitHub
parent 63b8172321
commit aee94b39ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
superset-frontend/src/features/tags/TagModal.tsx
View File

@ -88,6 +88,14 @@ const TagModal: React.FC<TagModalProps> = ({
setSavedQueriesToTag([]); setSavedQueriesToTag([]);
}; };
const clearTagForm = () => {
setTagName('');
setDescription('');
setDashboardsToTag([]);
setChartsToTag([]);
setSavedQueriesToTag([]);
};
useEffect(() => { useEffect(() => {
const resourceMap: { [key: string]: TaggableResourceOption[] } = { const resourceMap: { [key: string]: TaggableResourceOption[] } = {
[TaggableResources.Dashboard]: [], [TaggableResources.Dashboard]: [],
@ -225,7 +233,9 @@ const TagModal: React.FC<TagModalProps> = ({
}) })
.then(({ json = {} }) => { .then(({ json = {} }) => {
refreshData(); refreshData();
clearTagForm();
addSuccessToast(t('Tag updated')); addSuccessToast(t('Tag updated'));
onHide();
}) })
.catch(err => { .catch(err => {
addDangerToast(err.message || 'Error Updating Tag'); addDangerToast(err.message || 'Error Updating Tag');
@ -241,24 +251,19 @@ const TagModal: React.FC<TagModalProps> = ({
}) })
.then(({ json = {} }) => { .then(({ json = {} }) => {
refreshData(); refreshData();
clearTagForm();
addSuccessToast(t('Tag created')); addSuccessToast(t('Tag created'));
onHide();
}) })
.catch(err => addDangerToast(err.message || 'Error Creating Tag')); .catch(err => addDangerToast(err.message || 'Error Creating Tag'));
} }
onHide();
}; };
return ( return (
<Modal <Modal
title={modalTitle} title={modalTitle}
onHide={() => { onHide={() => {
if (clearOnHide) { if (clearOnHide) clearTagForm();
setTagName('');
setDescription('');
setDashboardsToTag([]);
setChartsToTag([]);
setSavedQueriesToTag([]);
}
onHide(); onHide();
}} }}
show={show} show={show}