pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(tag): update state to clear form on success (#25934)

This commit is contained in:
Hugh A. Miles II 2023-11-15 18:05:18 -05:00 committed by GitHub
parent 63b8172321
commit aee94b39ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
superset-frontend/src/features/tags/TagModal.tsx
View File

@ -88,6 +88,14 @@ const TagModal: React.FC<TagModalProps> = ({
setSavedQueriesToTag([]);
};
const clearTagForm = () => {
setTagName('');
setDescription('');
setDashboardsToTag([]);
setChartsToTag([]);
setSavedQueriesToTag([]);
};
useEffect(() => {
const resourceMap: { [key: string]: TaggableResourceOption[] } = {
[TaggableResources.Dashboard]: [],
@ -225,7 +233,9 @@ const TagModal: React.FC<TagModalProps> = ({
})
.then(({ json = {} }) => {
refreshData();
clearTagForm();
addSuccessToast(t('Tag updated'));
onHide();
})
.catch(err => {
addDangerToast(err.message || 'Error Updating Tag');
@ -241,24 +251,19 @@ const TagModal: React.FC<TagModalProps> = ({
})
.then(({ json = {} }) => {
refreshData();
clearTagForm();
addSuccessToast(t('Tag created'));
onHide();
})
.catch(err => addDangerToast(err.message || 'Error Creating Tag'));
}
onHide();
};
return (
<Modal
title={modalTitle}
onHide={() => {
if (clearOnHide) {
setTagName('');
setDescription('');
setDashboardsToTag([]);
setChartsToTag([]);
setSavedQueriesToTag([]);
}
if (clearOnHide) clearTagForm();
onHide();
}}
show={show}