pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(alerts/reports): implementing custom_width as an Antd number input (#27260)

This commit is contained in:
Jack 2024-03-15 13:10:00 -05:00 committed by GitHub
parent 13b6489b37
commit ad9024b040
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
superset-frontend/src/features/alerts/AlertReportModal.tsx
View File

@ -36,7 +36,7 @@ import {
import rison from 'rison';
import { useSingleViewResource } from 'src/views/CRUD/hooks';
import { Input } from 'src/components/Input';
import { InputNumber } from 'src/components/Input';
import { Switch } from 'src/components/Switch';
import Modal from 'src/components/Modal';
import Collapse from 'src/components/Collapse';
@ -873,6 +873,10 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
updateAlertState(name, parsedValue);
};
const onCustomWidthChange = (value: number | null | undefined) => {
updateAlertState('custom_width', value);
};
const onTimeoutVerifyChange = (
event: React.ChangeEvent<HTMLTextAreaElement | HTMLInputElement>,
) => {
@ -1542,12 +1546,14 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
>
<div className="control-label">{t('Screenshot width')}</div>
<div className="input-container">
<Input
<InputNumber
type="number"
name="custom_width"
value={currentAlert?.custom_width || ''}
value={currentAlert?.custom_width || undefined}
min={600}
max={2400}
placeholder={t('Input custom width in pixels')}
onChange={onInputChange}
onChange={onCustomWidthChange}
/>
</div>
</StyledInputContainer>