pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-16 10:39:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix act errors in DatabaseModal test (#21365)

Browse Source
This commit is contained in:
Lyndsi Kay Williams 2022-09-08 05:45:31 -05:00 committed by GitHub
parent 3fd0ba7b04
commit ab82b17af3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 43 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.test.jsx
View File

@ -26,11 +26,6 @@ import {
cleanup, cleanup,
act, act,
} from 'spec/helpers/testing-library'; } from 'spec/helpers/testing-library';
/* -- These imports are used for the mock functions that currently don't work
import {
testDatabaseConnection,
useSingleViewResource,
} from 'src/views/CRUD/hooks'; */
import DatabaseModal from './index'; import DatabaseModal from './index';
const dbProps = { const dbProps = {
@ -40,7 +35,6 @@ const dbProps = {
}; };
const DATABASE_FETCH_ENDPOINT = 'glob:*/api/v1/database/10'; const DATABASE_FETCH_ENDPOINT = 'glob:*/api/v1/database/10';
// const DATABASE_POST_ENDPOINT = 'glob:*/api/v1/database/';
const AVAILABLE_DB_ENDPOINT = 'glob:*/api/v1/database/available*'; const AVAILABLE_DB_ENDPOINT = 'glob:*/api/v1/database/available*';
const VALIDATE_PARAMS_ENDPOINT = 'glob:*/api/v1/database/validate_parameters*'; const VALIDATE_PARAMS_ENDPOINT = 'glob:*/api/v1/database/validate_parameters*';
@ -218,7 +212,7 @@ describe('DatabaseModal', () => {
afterEach(cleanup); afterEach(cleanup);
describe('Visual: New database connection', () => { describe('Visual: New database connection', () => {
it('renders the initial load of Step 1 correctly', async () => { test('renders the initial load of Step 1 correctly', () => {
// ---------- Components ---------- // ---------- Components ----------
// <TabHeader> - AntD header // <TabHeader> - AntD header
const closeButton = screen.getByLabelText('Close'); const closeButton = screen.getByLabelText('Close');
@ -319,13 +313,14 @@ describe('DatabaseModal', () => {
expect(preferredDbIcon).toHaveLength(4); expect(preferredDbIcon).toHaveLength(4);
}); });
it('renders the "Basic" tab of SQL Alchemy form (step 2 of 2) correctly', async () => { test('renders the "Basic" tab of SQL Alchemy form (step 2 of 2) correctly', async () => {
// On step 1, click dbButton to access SQL Alchemy form // On step 1, click dbButton to access SQL Alchemy form
userEvent.click( userEvent.click(
screen.getByRole('button', { screen.getByRole('button', {
name: /sqlite/i, name: /sqlite/i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
// ---------- Components ---------- // ---------- Components ----------
// <TabHeader> - AntD header // <TabHeader> - AntD header
@ -404,13 +399,14 @@ describe('DatabaseModal', () => {
}); });
}); });
it('renders the unexpanded "Advanced" tab correctly', async () => { test('renders the unexpanded "Advanced" tab correctly', async () => {
// On step 1, click dbButton to access step 2 // On step 1, click dbButton to access step 2
userEvent.click( userEvent.click(
screen.getByRole('button', { screen.getByRole('button', {
name: /sqlite/i, name: /sqlite/i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
// Click the "Advanced" tab // Click the "Advanced" tab
userEvent.click(screen.getByRole('tab', { name: /advanced/i })); userEvent.click(screen.getByRole('tab', { name: /advanced/i }));
@ -502,7 +498,7 @@ describe('DatabaseModal', () => {
}); });
}); });
it('renders the "Advanced" - SQL LAB tab correctly (unexpanded)', async () => { test('renders the "Advanced" - SQL LAB tab correctly (unexpanded)', async () => {
// ---------- Components ---------- // ---------- Components ----------
// On step 1, click dbButton to access step 2 // On step 1, click dbButton to access step 2
userEvent.click( userEvent.click(
@ -518,6 +514,7 @@ describe('DatabaseModal', () => {
name: /right sql lab adjust how this database will interact with sql lab\./i, name: /right sql lab adjust how this database will interact with sql lab\./i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
// ----- BEGIN STEP 2 (ADVANCED - SQL LAB) // ----- BEGIN STEP 2 (ADVANCED - SQL LAB)
// <TabHeader> - AntD header // <TabHeader> - AntD header
@ -665,7 +662,7 @@ describe('DatabaseModal', () => {
expect(tooltipIcons).toHaveLength(8); expect(tooltipIcons).toHaveLength(8);
}); });
it('renders the "Advanced" - PERFORMANCE tab correctly', async () => { test('renders the "Advanced" - PERFORMANCE tab correctly', async () => {
// ---------- Components ---------- // ---------- Components ----------
// On step 1, click dbButton to access step 2 // On step 1, click dbButton to access step 2
userEvent.click( userEvent.click(
@ -681,6 +678,7 @@ describe('DatabaseModal', () => {
name: /right performance adjust performance settings of this database\./i, name: /right performance adjust performance settings of this database\./i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
// ----- BEGIN STEP 2 (ADVANCED - PERFORMANCE) // ----- BEGIN STEP 2 (ADVANCED - PERFORMANCE)
// <TabHeader> - AntD header // <TabHeader> - AntD header
@ -727,7 +725,7 @@ describe('DatabaseModal', () => {
}); });
}); });
it('renders the "Advanced" - SECURITY tab correctly', async () => { test('renders the "Advanced" - SECURITY tab correctly', async () => {
// ---------- Components ---------- // ---------- Components ----------
// On step 1, click dbButton to access step 2 // On step 1, click dbButton to access step 2
userEvent.click( userEvent.click(
@ -743,6 +741,7 @@ describe('DatabaseModal', () => {
name: /right security add extra connection information\./i, name: /right security add extra connection information\./i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
// ----- BEGIN STEP 2 (ADVANCED - SECURITY) // ----- BEGIN STEP 2 (ADVANCED - SECURITY)
// <TabHeader> - AntD header // <TabHeader> - AntD header
@ -793,7 +792,7 @@ describe('DatabaseModal', () => {
}); });
}); });
it('renders the "Advanced" - OTHER tab correctly', async () => { test('renders the "Advanced" - OTHER tab correctly', async () => {
// ---------- Components ---------- // ---------- Components ----------
// On step 1, click dbButton to access step 2 // On step 1, click dbButton to access step 2
userEvent.click( userEvent.click(
@ -809,6 +808,7 @@ describe('DatabaseModal', () => {
name: /right other additional settings\./i, name: /right other additional settings\./i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
// ----- BEGIN STEP 2 (ADVANCED - OTHER) // ----- BEGIN STEP 2 (ADVANCED - OTHER)
// <TabHeader> - AntD header // <TabHeader> - AntD header
@ -863,7 +863,7 @@ describe('DatabaseModal', () => {
}); });
}); });
it('Dynamic form', async () => { test('Dynamic form', async () => {
// ---------- Components ---------- // ---------- Components ----------
// On step 1, click dbButton to access step 2 // On step 1, click dbButton to access step 2
userEvent.click( userEvent.click(
@ -871,13 +871,14 @@ describe('DatabaseModal', () => {
name: /postgresql/i, name: /postgresql/i,
}), }),
); );
expect(await screen.findByText(/step 2 of 3/i)).toBeInTheDocument();
expect.anything(); expect.anything();
}); });
}); });
describe('Functional: Create new database', () => { describe('Functional: Create new database', () => {
it('directs databases to the appropriate form (dynamic vs. SQL Alchemy)', () => { test('directs databases to the appropriate form (dynamic vs. SQL Alchemy)', async () => {
// ---------- Dynamic example (3-step form) // ---------- Dynamic example (3-step form)
// Click the PostgreSQL button to enter the dynamic form // Click the PostgreSQL button to enter the dynamic form
const postgreSQLButton = screen.getByRole('button', { const postgreSQLButton = screen.getByRole('button', {
@ -902,26 +903,24 @@ describe('DatabaseModal', () => {
userEvent.click(sqliteButton); userEvent.click(sqliteButton);
// SQL Alchemy form has 2 steps, seeing this text means the SQL Alchemy form is present // SQL Alchemy form has 2 steps, seeing this text means the SQL Alchemy form is present
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
const sqlAlchemyFormStepText = screen.getByText(/step 2 of 2/i); const sqlAlchemyFormStepText = screen.getByText(/step 2 of 2/i);
expect(sqlAlchemyFormStepText).toBeVisible(); expect(sqlAlchemyFormStepText).toBeVisible();
}); });
describe('SQL Alchemy form flow', () => { describe('SQL Alchemy form flow', () => {
beforeEach(() => { test('enters step 2 of 2 when proper database is selected', async () => {
userEvent.click( userEvent.click(
screen.getByRole('button', { screen.getByRole('button', {
name: /sqlite/i, name: /sqlite/i,
}), }),
); );
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
}); });
it('enters step 2 of 2 when proper database is selected', () => { test('runs fetchResource when "Connect" is clicked', () => {
const step2text = screen.getByText(/step 2 of 2/i);
expect(step2text).toBeVisible();
});
it('runs fetchResource when "Connect" is clicked', () => {
/* ---------- 🐞 TODO (lyndsiWilliams): function mock is not currently working 🐞 ---------- /* ---------- 🐞 TODO (lyndsiWilliams): function mock is not currently working 🐞 ----------
// Mock useSingleViewResource // Mock useSingleViewResource
@ -939,7 +938,14 @@ describe('DatabaseModal', () => {
}); });
describe('step 2 component interaction', () => { describe('step 2 component interaction', () => {
it('properly interacts with textboxes', () => { test('properly interacts with textboxes', async () => {
userEvent.click(
screen.getByRole('button', {
name: /sqlite/i,
}),
);
expect(await screen.findByText(/step 2 of 2/i)).toBeInTheDocument();
const dbNametextBox = screen.getByTestId('database-name-input'); const dbNametextBox = screen.getByTestId('database-name-input');
expect(dbNametextBox).toHaveValue('SQLite'); expect(dbNametextBox).toHaveValue('SQLite');
@ -955,7 +961,7 @@ describe('DatabaseModal', () => {
expect(sqlAlchemyURItextBox).toHaveValue('Different text'); expect(sqlAlchemyURItextBox).toHaveValue('Different text');
}); });
it('runs testDatabaseConnection when "TEST CONNECTION" is clicked', () => { test('runs testDatabaseConnection when "TEST CONNECTION" is clicked', () => {
/* ---------- 🐞 TODO (lyndsiWilliams): function mock is not currently working 🐞 ---------- /* ---------- 🐞 TODO (lyndsiWilliams): function mock is not currently working 🐞 ----------
// Mock testDatabaseConnection // Mock testDatabaseConnection
@ -977,20 +983,26 @@ describe('DatabaseModal', () => {
}); });
describe('Dynamic form flow', () => { describe('Dynamic form flow', () => {
beforeEach(() => { test('enters step 2 of 3 when proper database is selected', async () => {
expect(await screen.findByText(/step 1 of 3/i)).toBeInTheDocument();
userEvent.click( userEvent.click(
screen.getByRole('button', { screen.getByRole('button', {
name: /postgresql/i, name: /postgresql/i,
}), }),
); );
}); expect(await screen.findByText(/step 2 of 3/i)).toBeInTheDocument();
it('enters step 2 of 3 when proper database is selected', () => {
const step2of3text = screen.getByText(/step 2 of 3/i); const step2of3text = screen.getByText(/step 2 of 3/i);
expect(step2of3text).toBeVisible(); expect(step2of3text).toBeVisible();
}); });
it('enters form credentials and runs fetchResource when "Connect" is clicked', () => { test('enters form credentials and runs fetchResource when "Connect" is clicked', async () => {
userEvent.click(
screen.getByRole('button', {
name: /postgresql/i,
}),
);
const textboxes = screen.getAllByRole('textbox'); const textboxes = screen.getAllByRole('textbox');
const hostField = textboxes[0]; const hostField = textboxes[0];
const portField = screen.getByRole('spinbutton'); const portField = screen.getByRole('spinbutton');
@ -1010,6 +1022,7 @@ describe('DatabaseModal', () => {
userEvent.type(usernameField, 'testdb'); userEvent.type(usernameField, 'testdb');
userEvent.type(passwordField, 'demoPassword'); userEvent.type(passwordField, 'demoPassword');
expect(await screen.findByDisplayValue(/5432/i)).toBeInTheDocument();
expect(hostField).toHaveValue('localhost'); expect(hostField).toHaveValue('localhost');
expect(portField).toHaveValue(5432); expect(portField).toHaveValue(5432);
expect(databaseNameField).toHaveValue('postgres'); expect(databaseNameField).toHaveValue('postgres');
@ -1033,7 +1046,7 @@ describe('DatabaseModal', () => {
}); });
describe('Import database flow', () => { describe('Import database flow', () => {
it('imports a file', () => { test('imports a file', async () => {
const importDbButton = screen.getByTestId('import-database-btn'); const importDbButton = screen.getByTestId('import-database-btn');
expect(importDbButton).toBeVisible(); expect(importDbButton).toBeVisible();
@ -1064,7 +1077,7 @@ describe('DatabaseModal', () => {
await renderAndWait(); await renderAndWait();
}); });
it('enters step 2 of 3 when proper database is selected', () => { test('enters step 2 of 3 when proper database is selected', () => {
const step2of3text = screen.getByText(/step 2 of 3/i); const step2of3text = screen.getByText(/step 2 of 3/i);
expect(step2of3text).toBeVisible(); expect(step2of3text).toBeVisible();
}); });