pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Delete unused funcs and comments

This commit is contained in:
rtexelm 2024-06-28 02:14:26 -04:00
parent d159d904d8
commit aad307caba
2 changed files with 1 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx
View File

@ -141,16 +141,7 @@ export class UnwrappedDragDroppable extends PureComponent {
dropIndicator !== prevState.dropIndicator ||
isDraggingOver !== prevProps.isDraggingOver ||
index !== prevProps.index;
// console.log(
// 'index',
// index,
// 'isTabsType:',
// isTabsType,
// 'component:',
// component,
// 'validStateChange:',
// validStateChange,
// );
if (onDropIndicatorChange && isTabsType && validStateChange) {
onDropIndicatorChange({ dropIndicator, isDraggingOver, index });
}

27
superset-frontend/src/dashboard/components/gridComponents/Tab.jsx
View File

@ -89,19 +89,6 @@ const TabTitleContainer = styled.div`
`}
`;
// .drop-indicator {
// display: block;
// background-color: ${theme.colors.primary.base};
// position: absolute;
// z-index: 10;
// opacity: 0.3;
// width: 100%;
// height: 100%;
// &.drop-indicator--forbidden {
// background-color: ${theme.colors.error.light1};
// }
// }
const TitleDropIndicator = styled.div`
&.drop-indicator {
position: absolute;
@ -121,7 +108,6 @@ class Tab extends PureComponent {
this.handleOnHover = this.handleOnHover.bind(this);
this.handleTopDropTargetDrop = this.handleTopDropTargetDrop.bind(this);
this.handleChangeTab = this.handleChangeTab.bind(this);
this.logDropIndicator = this.logDropIndicator.bind(this);
// this.handleGetDropPosition = this.handleGetDropPosition.bind(this);
}
@ -150,22 +136,9 @@ class Tab extends PureComponent {
}
handleOnHover() {
// this.logDropIndicator(dropIndicatorProps);
this.props.onHoverTab();
}
logDropIndicator(dropIndicatorProps) {
if (dropIndicatorProps?.dropIndicator) {
// eslint-disable-next-line no-console
console.log('dropIndicatorProps:', dropIndicatorProps);
// this.setState({ dropPosition: dropIndicatorProps.dropIndicator});
}
}
// handleGetDropPosition(dropIndicator, isDraggingOver) {
// this.props.onDropPositionChange(dropIndicator, isDraggingOver);
// }
handleTopDropTargetDrop(dropResult) {
if (dropResult) {
this.props.handleComponentDrop({