mirror of https://github.com/apache/superset.git
chore: Change chart_is_fav to chart_is_favorite (#12075)
* Change chart_is_fav to chart_is_favorite * Trigger cypress tests * Retrigger cypress tests * Retrigger all tests * Dashboard * Additions
This commit is contained in:
parent
9b110b2aa5
commit
a52031a55e
|
@ -79,7 +79,7 @@ describe('Dashboard top-level controls', () => {
|
||||||
'ant-dropdown-menu-item-disabled',
|
'ant-dropdown-menu-item-disabled',
|
||||||
);
|
);
|
||||||
|
|
||||||
// wait all charts force refreshed
|
// wait all charts force refreshed.
|
||||||
cy.wait(aliases, { responseTimeout: 15000 }).then(xhrs => {
|
cy.wait(aliases, { responseTimeout: 15000 }).then(xhrs => {
|
||||||
xhrs.forEach(async xhr => {
|
xhrs.forEach(async xhr => {
|
||||||
const responseBody = await readResponseBlob(xhr.response.body);
|
const responseBody = await readResponseBlob(xhr.response.body);
|
||||||
|
|
|
@ -56,8 +56,8 @@ type FilterOperator =
|
||||||
| 'chart_all_text'
|
| 'chart_all_text'
|
||||||
| 'dataset_is_null_or_empty'
|
| 'dataset_is_null_or_empty'
|
||||||
| 'between'
|
| 'between'
|
||||||
| 'dashboard_is_fav'
|
| 'dashboard_is_favorite'
|
||||||
| 'chart_is_fav';
|
| 'chart_is_favorite';
|
||||||
|
|
||||||
export interface Filter {
|
export interface Filter {
|
||||||
Header: ReactNode;
|
Header: ReactNode;
|
||||||
|
@ -123,6 +123,6 @@ export enum FilterOperators {
|
||||||
chartAllText = 'chart_all_text',
|
chartAllText = 'chart_all_text',
|
||||||
datasetIsNullOrEmpty = 'dataset_is_null_or_empty',
|
datasetIsNullOrEmpty = 'dataset_is_null_or_empty',
|
||||||
between = 'between',
|
between = 'between',
|
||||||
dashboardIsFav = 'dashboard_is_fav',
|
dashboardIsFav = 'dashboard_is_favorite',
|
||||||
chartIsFav = 'chart_is_fav',
|
chartIsFav = 'chart_is_favorite',
|
||||||
}
|
}
|
||||||
|
|
|
@ -92,7 +92,7 @@ function ChartTable({
|
||||||
} else {
|
} else {
|
||||||
filters.push({
|
filters.push({
|
||||||
id: 'id',
|
id: 'id',
|
||||||
operator: 'chart_is_fav',
|
operator: 'chart_is_favorite',
|
||||||
value: true,
|
value: true,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
|
@ -99,7 +99,7 @@ function DashboardTable({
|
||||||
} else {
|
} else {
|
||||||
filters.push({
|
filters.push({
|
||||||
id: 'id',
|
id: 'id',
|
||||||
operator: 'dashboard_is_fav',
|
operator: 'dashboard_is_favorite',
|
||||||
value: true,
|
value: true,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
|
@ -50,7 +50,7 @@ class ChartFavoriteFilter(BaseFavoriteFilter): # pylint: disable=too-few-public
|
||||||
Custom filter for the GET list that filters all charts that a user has favored
|
Custom filter for the GET list that filters all charts that a user has favored
|
||||||
"""
|
"""
|
||||||
|
|
||||||
arg_name = "chart_is_fav"
|
arg_name = "chart_is_favorite"
|
||||||
class_name = "slice"
|
class_name = "slice"
|
||||||
model = Slice
|
model = Slice
|
||||||
|
|
||||||
|
|
|
@ -51,7 +51,7 @@ class DashboardFavoriteFilter(
|
||||||
Custom filter for the GET list that filters all dashboards that a user has favored
|
Custom filter for the GET list that filters all dashboards that a user has favored
|
||||||
"""
|
"""
|
||||||
|
|
||||||
arg_name = "dashboard_is_fav"
|
arg_name = "dashboard_is_favorite"
|
||||||
class_name = "Dashboard"
|
class_name = "Dashboard"
|
||||||
model = Dashboard
|
model = Dashboard
|
||||||
|
|
||||||
|
|
|
@ -923,7 +923,7 @@ class TestChartApi(SupersetTestCase, ApiOwnersTestCaseMixin):
|
||||||
)
|
)
|
||||||
|
|
||||||
arguments = {
|
arguments = {
|
||||||
"filters": [{"col": "id", "opr": "chart_is_fav", "value": True}],
|
"filters": [{"col": "id", "opr": "chart_is_favorite", "value": True}],
|
||||||
"order_column": "slice_name",
|
"order_column": "slice_name",
|
||||||
"order_direction": "asc",
|
"order_direction": "asc",
|
||||||
"keys": ["none"],
|
"keys": ["none"],
|
||||||
|
|
|
@ -368,7 +368,7 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
|
||||||
)
|
)
|
||||||
|
|
||||||
arguments = {
|
arguments = {
|
||||||
"filters": [{"col": "id", "opr": "dashboard_is_fav", "value": True}],
|
"filters": [{"col": "id", "opr": "dashboard_is_favorite", "value": True}],
|
||||||
"order_column": "dashboard_title",
|
"order_column": "dashboard_title",
|
||||||
"order_direction": "asc",
|
"order_direction": "asc",
|
||||||
"keys": ["none"],
|
"keys": ["none"],
|
||||||
|
@ -431,7 +431,7 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
|
||||||
.all()
|
.all()
|
||||||
)
|
)
|
||||||
arguments = {
|
arguments = {
|
||||||
"filters": [{"col": "id", "opr": "dashboard_is_fav", "value": False}],
|
"filters": [{"col": "id", "opr": "dashboard_is_favorite", "value": False}],
|
||||||
"order_column": "dashboard_title",
|
"order_column": "dashboard_title",
|
||||||
"order_direction": "asc",
|
"order_direction": "asc",
|
||||||
"keys": ["none"],
|
"keys": ["none"],
|
||||||
|
|
Loading…
Reference in New Issue