chore: Change chart_is_fav to chart_is_favorite (#12075)

* Change chart_is_fav to chart_is_favorite

* Trigger cypress tests

* Retrigger cypress tests

* Retrigger all tests

* Dashboard

* Additions

superset-frontend/cypress-base/cypress/integration/dashboard/controls.test.js

@@ -79,7 +79,7 @@ describe('Dashboard top-level controls', () => {
       'ant-dropdown-menu-item-disabled',
     );
 
-    // wait all charts force refreshed
+    // wait all charts force refreshed.
     cy.wait(aliases, { responseTimeout: 15000 }).then(xhrs => {
       xhrs.forEach(async xhr => {
         const responseBody = await readResponseBlob(xhr.response.body);

superset-frontend/src/components/ListView/types.ts

@@ -56,8 +56,8 @@ type FilterOperator =
   | 'chart_all_text'
   | 'dataset_is_null_or_empty'
   | 'between'
-  | 'dashboard_is_fav'
+  | 'dashboard_is_favorite'
-  | 'chart_is_fav';
+  | 'chart_is_favorite';
 
 export interface Filter {
   Header: ReactNode;
@@ -123,6 +123,6 @@ export enum FilterOperators {
   chartAllText = 'chart_all_text',
   datasetIsNullOrEmpty = 'dataset_is_null_or_empty',
   between = 'between',
-  dashboardIsFav = 'dashboard_is_fav',
+  dashboardIsFav = 'dashboard_is_favorite',
-  chartIsFav = 'chart_is_fav',
+  chartIsFav = 'chart_is_favorite',
 }

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx

@@ -92,7 +92,7 @@ function ChartTable({
     } else {
       filters.push({
         id: 'id',
-        operator: 'chart_is_fav',
+        operator: 'chart_is_favorite',
         value: true,
       });
     }

superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx

@@ -99,7 +99,7 @@ function DashboardTable({
     } else {
       filters.push({
         id: 'id',
-        operator: 'dashboard_is_fav',
+        operator: 'dashboard_is_favorite',
         value: true,
       });
     }

superset/charts/filters.py

@@ -50,7 +50,7 @@ class ChartFavoriteFilter(BaseFavoriteFilter):  # pylint: disable=too-few-public
     Custom filter for the GET list that filters all charts that a user has favored
     """
 
-    arg_name = "chart_is_fav"
+    arg_name = "chart_is_favorite"
     class_name = "slice"
     model = Slice
 

superset/dashboards/filters.py

@@ -51,7 +51,7 @@ class DashboardFavoriteFilter(
     Custom filter for the GET list that filters all dashboards that a user has favored
     """
 
-    arg_name = "dashboard_is_fav"
+    arg_name = "dashboard_is_favorite"
     class_name = "Dashboard"
     model = Dashboard
 

tests/charts/api_tests.py

@@ -923,7 +923,7 @@ class TestChartApi(SupersetTestCase, ApiOwnersTestCaseMixin):
         )
 
         arguments = {
-            "filters": [{"col": "id", "opr": "chart_is_fav", "value": True}],
+            "filters": [{"col": "id", "opr": "chart_is_favorite", "value": True}],
             "order_column": "slice_name",
             "order_direction": "asc",
             "keys": ["none"],

tests/dashboards/api_tests.py

@@ -368,7 +368,7 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
         )
 
         arguments = {
-            "filters": [{"col": "id", "opr": "dashboard_is_fav", "value": True}],
+            "filters": [{"col": "id", "opr": "dashboard_is_favorite", "value": True}],
             "order_column": "dashboard_title",
             "order_direction": "asc",
             "keys": ["none"],
@@ -431,7 +431,7 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
             .all()
         )
         arguments = {
-            "filters": [{"col": "id", "opr": "dashboard_is_fav", "value": False}],
+            "filters": [{"col": "id", "opr": "dashboard_is_favorite", "value": False}],
             "order_column": "dashboard_title",
             "order_direction": "asc",
             "keys": ["none"],