pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: tests for #24249 (#24251)

This commit is contained in:
Beto Dealmeida 2023-05-31 09:23:07 -07:00 committed by GitHub
parent 5853574b98
commit a3bbe35fb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
superset-frontend/src/dashboard/util/permissionUtils.test.ts
View File

@ -61,7 +61,6 @@ const owner: Owner = {
first_name: 'Test',
id: ownerUser.userId!,
last_name: 'User',
username: ownerUser.username,
};
const sqlLabUser: UserWithPermissionsAndRoles = {

2
superset-frontend/src/dashboard/util/permissionUtils.ts
View File

@ -50,7 +50,7 @@ export const canUserEditDashboard = (
) =>
isUserWithPermissionsAndRoles(user) &&
(isUserAdmin(user) || isUserDashboardOwner(dashboard, user)) &&
findPermission('can_write', 'Dashboard', user.roles);
findPermission('can_write', 'Dashboard', user?.roles);
export function canUserAccessSqlLab(
user?: UserWithPermissionsAndRoles | UndefinedUser,

2
superset-frontend/src/types/Owner.ts
View File

@ -25,6 +25,4 @@ export default interface Owner {
first_name: string;
id: number;
last_name: string;
username: string;
email?: string;
}