mirror of
https://github.com/apache/superset.git
synced 2024-09-06 13:57:40 -04:00
fix: Dataset field required 2 clicks to select when dashboard was empty (#15985)
This commit is contained in:
parent
f1b57c0d88
commit
a3a762e5a7
@ -510,7 +510,8 @@ const FiltersConfigForm = (
|
|||||||
setHasDefaultValue,
|
setHasDefaultValue,
|
||||||
] = useDefaultValue(formFilter, filterToEdit);
|
] = useDefaultValue(formFilter, filterToEdit);
|
||||||
|
|
||||||
const showDataset = !datasetId || datasetDetails;
|
const showDataset =
|
||||||
|
!datasetId || datasetDetails || formFilter?.dataset?.label;
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (hasDataset && hasFilledDataset && hasDefaultValue && isDataDirty) {
|
if (hasDataset && hasFilledDataset && hasDefaultValue && isDataDirty) {
|
||||||
|
@ -171,7 +171,8 @@ export function FiltersConfigModal({
|
|||||||
setCurrentFilterId(initialCurrentFilterId);
|
setCurrentFilterId(initialCurrentFilterId);
|
||||||
setRemovedFilters({});
|
setRemovedFilters({});
|
||||||
setSaveAlertVisible(false);
|
setSaveAlertVisible(false);
|
||||||
setFormValues({ filters: {}, changed: false });
|
setFormValues({ filters: {} });
|
||||||
|
form.setFieldsValue({ changed: false });
|
||||||
};
|
};
|
||||||
|
|
||||||
const getFilterTitle = (id: string) =>
|
const getFilterTitle = (id: string) =>
|
||||||
|
Loading…
Reference in New Issue
Block a user