pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 08:39:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

[bugfix] bignumber comparison wrong with neg values (#1743)

Browse Source 
* [bugfix] bignumber comparison wrong with neg values

* Handling zero div
This commit is contained in:
Maxime Beauchemin 2016-12-03 20:05:43 -08:00 committed by GitHub
parent b045075a96
commit a3106bcb3d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset/assets/visualizations/big_number.js
View File

@ -35,7 +35,10 @@ function bigNumberVis(slice) {
if (json.compare_lag > 0) {
const pos = data.length - (json.compare_lag + 1);
if (pos >= 0) {
vCompare = (v / data[pos][1]) - 1;
const vAnchor = data[pos][1];
if (vAnchor !== 0) {
vCompare = (v - vAnchor) / Math.abs(vAnchor);
}
}
}
const dateExt = d3.extent(data, (d) => d[0]);