pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Removes unused cache cleanup (#26648)

This commit is contained in:
Michael S. Molina 2024-01-17 16:34:45 -03:00 committed by GitHub
parent f8d25612ba
commit 9724abf090
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset/commands/chart/delete.py
View File

@ -31,7 +31,6 @@ from superset.daos.chart import ChartDAO
from superset.daos.exceptions import DAODeleteFailedError from superset.daos.exceptions import DAODeleteFailedError
from superset.daos.report import ReportScheduleDAO from superset.daos.report import ReportScheduleDAO
from superset.exceptions import SupersetSecurityException from superset.exceptions import SupersetSecurityException
from superset.models.dashboard import Dashboard
from superset.models.slice import Slice from superset.models.slice import Slice
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -46,9 +45,6 @@ class DeleteChartCommand(BaseCommand):
self.validate() self.validate()
assert self._models assert self._models
for model_id in self._model_ids:
Dashboard.clear_cache_for_slice(slice_id=model_id)
try: try:
ChartDAO.delete(self._models) ChartDAO.delete(self._models)
except DAODeleteFailedError as ex: except DAODeleteFailedError as ex:

34
superset/models/dashboard.py
View File

@ -41,13 +41,11 @@ from sqlalchemy import (
from sqlalchemy.engine.base import Connection from sqlalchemy.engine.base import Connection
from sqlalchemy.orm import relationship, subqueryload from sqlalchemy.orm import relationship, subqueryload
from sqlalchemy.orm.mapper import Mapper from sqlalchemy.orm.mapper import Mapper
from sqlalchemy.sql import join, select
from sqlalchemy.sql.elements import BinaryExpression from sqlalchemy.sql.elements import BinaryExpression
from superset import app, db, is_feature_enabled, security_manager from superset import app, db, is_feature_enabled, security_manager
from superset.connectors.sqla.models import BaseDatasource, SqlaTable from superset.connectors.sqla.models import BaseDatasource, SqlaTable
from superset.daos.datasource import DatasourceDAO from superset.daos.datasource import DatasourceDAO
from superset.extensions import cache_manager
from superset.models.helpers import AuditMixinNullable, ImportExportMixin from superset.models.helpers import AuditMixinNullable, ImportExportMixin
from superset.models.slice import Slice from superset.models.slice import Slice
from superset.models.user_attributes import UserAttribute from superset.models.user_attributes import UserAttribute
@ -55,7 +53,6 @@ from superset.tasks.thumbnails import cache_dashboard_thumbnail
from superset.tasks.utils import get_current_user from superset.tasks.utils import get_current_user
from superset.thumbnails.digest import get_dashboard_digest from superset.thumbnails.digest import get_dashboard_digest
from superset.utils import core as utils from superset.utils import core as utils
from superset.utils.decorators import debounce
metadata = Model.metadata # pylint: disable=no-member metadata = Model.metadata # pylint: disable=no-member
config = app.config config = app.config
@ -132,7 +129,6 @@ DashboardRoles = Table(
) )
# pylint: disable=too-many-public-methods
class Dashboard(AuditMixinNullable, ImportExportMixin, Model): class Dashboard(AuditMixinNullable, ImportExportMixin, Model):
"""The dashboard object!""" """The dashboard object!"""
@ -317,36 +313,6 @@ class Dashboard(AuditMixinNullable, ImportExportMixin, Model):
force=True, force=True,
) )
@debounce(0.1)
def clear_cache(self) -> None:
cache_manager.cache.delete_memoized(Dashboard.datasets_trimmed_for_slices, self)
@classmethod
@debounce(0.1)
def clear_cache_for_slice(cls, slice_id: int) -> None:
filter_query = select([dashboard_slices.c.dashboard_id], distinct=True).where(
dashboard_slices.c.slice_id == slice_id
)
for (dashboard_id,) in db.engine.execute(filter_query):
cls(id=dashboard_id).clear_cache()
@classmethod
@debounce(0.1)
def clear_cache_for_datasource(cls, datasource_id: int) -> None:
filter_query = select(
[dashboard_slices.c.dashboard_id],
distinct=True,
).select_from(
join(
dashboard_slices,
Slice,
(Slice.id == dashboard_slices.c.slice_id)
& (Slice.datasource_id == datasource_id),
)
)
for (dashboard_id,) in db.engine.execute(filter_query):
cls(id=dashboard_id).clear_cache()
@classmethod @classmethod
def export_dashboards( # pylint: disable=too-many-locals def export_dashboards( # pylint: disable=too-many-locals
cls, cls,