pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): Force native filters into vertical orientation when FF off (#22265)

This commit is contained in:
Cody Leff 2022-11-29 14:47:48 -07:00 committed by GitHub
parent a642d126f8
commit 969c9634f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
View File

@ -246,7 +246,10 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
state => state.dashboardState.fullSizeChartId, state => state.dashboardState.fullSizeChartId,
); );
const filterBarOrientation = useSelector<RootState, FilterBarOrientation>( const filterBarOrientation = useSelector<RootState, FilterBarOrientation>(
({ dashboardInfo }) => dashboardInfo.filterBarOrientation, ({ dashboardInfo }) =>
isFeatureEnabled(FeatureFlag.HORIZONTAL_FILTER_BAR)
? dashboardInfo.filterBarOrientation
: FilterBarOrientation.VERTICAL,
); );
const handleChangeTab = useCallback( const handleChangeTab = useCallback(

7
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
View File

@ -26,6 +26,8 @@ import {
SupersetTheme, SupersetTheme,
t, t,
isNativeFilter, isNativeFilter,
isFeatureEnabled,
FeatureFlag,
} from '@superset-ui/core'; } from '@superset-ui/core';
import { import {
createHtmlPortalNode, createHtmlPortalNode,
@ -56,7 +58,10 @@ const FilterControls: FC<FilterControlsProps> = ({
onFilterSelectionChange, onFilterSelectionChange,
}) => { }) => {
const filterBarOrientation = useSelector<RootState, FilterBarOrientation>( const filterBarOrientation = useSelector<RootState, FilterBarOrientation>(
state => state.dashboardInfo.filterBarOrientation, ({ dashboardInfo }) =>
isFeatureEnabled(FeatureFlag.HORIZONTAL_FILTER_BAR)
? dashboardInfo.filterBarOrientation
: FilterBarOrientation.VERTICAL,
); );
const [overflowedIds, setOverflowedIds] = useState<string[]>([]); const [overflowedIds, setOverflowedIds] = useState<string[]>([]);