pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-18 11:39:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf(word-cloud): reduce render to improve performance (#21504)

Browse Source
This commit is contained in:
Stephen Liu 2022-09-19 20:08:36 +08:00 committed by GitHub
parent 7d2f07e78f
commit 94a724e49b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
superset-frontend/plugins/plugin-chart-word-cloud/package.json
View File

@ -36,6 +36,7 @@
}, },
"peerDependencies": { "peerDependencies": {
"@types/react": "*", "@types/react": "*",
"@types/lodash": "*",
"@superset-ui/chart-controls": "*", "@superset-ui/chart-controls": "*",
"@superset-ui/core": "*", "@superset-ui/core": "*",
"react": "^16.13.1" "react": "^16.13.1"

5
superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx
View File

@ -31,6 +31,7 @@ import {
seed, seed,
CategoricalColorScale, CategoricalColorScale,
} from '@superset-ui/core'; } from '@superset-ui/core';
import { isEqual } from 'lodash';
const seedRandom = seed('superset-ui'); const seedRandom = seed('superset-ui');
export const ROTATION = { export const ROTATION = {
@ -134,8 +135,8 @@ class WordCloud extends React.PureComponent<
const { data, encoding, width, height, rotation } = this.props; const { data, encoding, width, height, rotation } = this.props;
if ( if (
prevProps.data !== data || !isEqual(prevProps.data, data) ||
prevProps.encoding !== encoding || !isEqual(prevProps.encoding, encoding) ||
prevProps.width !== width || prevProps.width !== width ||
prevProps.height !== height || prevProps.height !== height ||
prevProps.rotation !== rotation prevProps.rotation !== rotation