pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-18 11:39:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: Remove legacy sql alchemy db connection link from G Sheet connection (#19450)

Browse Source 
* feat: Remove legacy sql alchemy db connection link from G Sheet connection

* resolve comment
This commit is contained in:
Smart-Codi 2022-04-14 16:34:15 -04:00 committed by GitHub
parent 158852d074
commit 94075983f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
View File

@ -139,6 +139,8 @@ const errorAlertMapping = {
), ),
}, },
}; };
const googleSheetConnectionEngine = 'gsheets';
interface DatabaseModalProps { interface DatabaseModalProps {
addDangerToast: (msg: string) => void; addDangerToast: (msg: string) => void;
addSuccessToast: (msg: string) => void; addSuccessToast: (msg: string) => void;
@ -1575,6 +1577,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
validationErrors={validationErrors} validationErrors={validationErrors}
/> />
<div css={(theme: SupersetTheme) => infoTooltip(theme)}> <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
{dbModel.engine !== googleSheetConnectionEngine && (
<>
<Button <Button
data-test="sqla-connect-btn" data-test="sqla-connect-btn"
buttonStyle="link" buttonStyle="link"
@ -1601,6 +1605,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
)} )}
viewBox="0 -6 24 24" viewBox="0 -6 24 24"
/> />
</>
)}
</div> </div>
{/* Step 2 */} {/* Step 2 */}
{showDBError && errorAlert()} {showDBError && errorAlert()}