pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): fix control x to stop query (#21899)

Browse Source
This commit is contained in:
Phillip Kelley-Dotson 2022-10-24 09:51:22 -07:00 committed by GitHub
parent c19708b432
commit 88e98d576c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
View File

@ -219,6 +219,7 @@ const SqlEditor = ({
if (latestQuery && ['running', 'pending'].indexOf(latestQuery.state) >= 0) {
dispatch(postStopQuery(latestQuery));
}
return false;
};
const runQuery = () => {
@ -244,7 +245,6 @@ const SqlEditor = ({
const getHotkeyConfig = () => {
// Get the user's OS
const userOS = detectOS();
const base = [
{
name: 'runQuery1',
@ -326,18 +326,21 @@ const SqlEditor = ({
window.addEventListener('resize', handleWindowResizeWithThrottle);
window.addEventListener('beforeunload', onBeforeUnload);
// setup hotkeys
const hotkeys = getHotkeyConfig();
hotkeys.forEach(keyConfig => {
Mousetrap.bind([keyConfig.key], keyConfig.func);
});
return () => {
window.removeEventListener('resize', handleWindowResizeWithThrottle);
window.removeEventListener('beforeunload', onBeforeUnload);
};
}, []);
useEffect(() => {
// setup hotkeys
Mousetrap.reset();
const hotkeys = getHotkeyConfig();
hotkeys.forEach(keyConfig => {
Mousetrap.bind([keyConfig.key], keyConfig.func);
});
}, [latestQuery]);
const onResizeStart = () => {
// Set the heights on the ace editor and the ace content area after drag starts
// to smooth out the visual transition to the new heights when drag ends