[sip-15] Enabling SIP-15 by default (#9017)

This commit is contained in:
John Bodley 2020-02-03 10:37:29 -08:00 committed by GitHub
parent 010fdd20a1
commit 848c565c8c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions

View File

@ -46,6 +46,13 @@ now uses UTC for the tooltips and default placeholder timestamps (sans timezone)
have changed. FLASK_APP should be updated to `superset.app:create_app()` and Celery Workers
should be started with `--app=superset.tasks.celery_app:app`
* [9017](https://github.com/apache/incubator-superset/pull/9017): `SIP_15_ENABLED` now
defaults to True which ensures that for all new SQL charts the time filter will behave
like [start, end). Existing deployments should either disable this feature to keep the
status quo or inform their users of this change prior to enabling the flag. The
`SIP_15_GRACE_PERIOD_END` option provides a mechanism for specifying how long chart
owners have to migrate their charts (the default is indefinite).
## 0.35.0
* [8370](https://github.com/apache/incubator-superset/pull/8370): Deprecates

View File

@ -749,7 +749,7 @@ SQLALCHEMY_EXAMPLES_URI = None
#
# Note if no end date for the grace period is specified then the grace period is
# indefinite.
SIP_15_ENABLED = False
SIP_15_ENABLED = True
SIP_15_GRACE_PERIOD_END: Optional[date] = None # exclusive
SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["unknown", "inclusive"]
SIP_15_TOAST_MESSAGE = (

View File

@ -244,6 +244,7 @@ class CoreTests(SupersetTestCase):
"metric": "sum__value",
"row_limit": 5000,
"slice_id": slice_id,
"time_range_endpoints": ["inclusive", "exclusive"],
}
# Changing name and save as a new slice
resp = self.client.post(
@ -265,6 +266,7 @@ class CoreTests(SupersetTestCase):
"row_limit": 5000,
"slice_id": new_slice_id,
"time_range": "now",
"time_range_endpoints": ["inclusive", "exclusive"],
}
# Setting the name back to its original name by overwriting new slice
self.client.post(