mirror of https://github.com/apache/superset.git
Revert "Binding key Q to the running the query in explore view" (#713)
This commit is contained in:
parent
19983147a3
commit
8135c240dc
|
@ -8,8 +8,6 @@ var jQuery = window.jQuery = $;
|
||||||
var px = require('./modules/caravel.js');
|
var px = require('./modules/caravel.js');
|
||||||
var showModal = require('./modules/utils.js').showModal;
|
var showModal = require('./modules/utils.js').showModal;
|
||||||
|
|
||||||
var isQueryRunning = false;
|
|
||||||
|
|
||||||
require('jquery-ui');
|
require('jquery-ui');
|
||||||
$.widget.bridge('uitooltip', $.ui.tooltip); // Shutting down jq-ui tooltips
|
$.widget.bridge('uitooltip', $.ui.tooltip); // Shutting down jq-ui tooltips
|
||||||
require('bootstrap');
|
require('bootstrap');
|
||||||
|
@ -58,10 +56,6 @@ function prepForm() {
|
||||||
}
|
}
|
||||||
|
|
||||||
function query(force, pushState) {
|
function query(force, pushState) {
|
||||||
if (isQueryRunning) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
isQueryRunning = true;
|
|
||||||
if (force === undefined) {
|
if (force === undefined) {
|
||||||
force = false;
|
force = false;
|
||||||
}
|
}
|
||||||
|
@ -77,7 +71,6 @@ function query(force, pushState) {
|
||||||
history.pushState({}, document.title, slice.querystring());
|
history.pushState({}, document.title, slice.querystring());
|
||||||
}
|
}
|
||||||
slice.render(force);
|
slice.render(force);
|
||||||
isQueryRunning = false;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function initExploreView() {
|
function initExploreView() {
|
||||||
|
@ -489,9 +482,4 @@ $(document).ready(function () {
|
||||||
|
|
||||||
$('div.toggle').addClass('pull-right');
|
$('div.toggle').addClass('pull-right');
|
||||||
slice.bindResizeToWindowResize();
|
slice.bindResizeToWindowResize();
|
||||||
document.addEventListener("keyup", function (k) {
|
|
||||||
if (k.key === 'q' || k.key === 'Q') {
|
|
||||||
query(true);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
|
@ -43,9 +43,3 @@ framework, in the meantime, we've tagged a few pull requests as
|
||||||
visualizations.
|
visualizations.
|
||||||
|
|
||||||
https://github.com/airbnb/caravel/issues?q=label%3Aexample+is%3Aclosed
|
https://github.com/airbnb/caravel/issues?q=label%3Aexample+is%3Aclosed
|
||||||
|
|
||||||
|
|
||||||
Is there shortcut for the Query button
|
|
||||||
--------------------------------------
|
|
||||||
|
|
||||||
Yes, `q` or `Q` will do it.
|
|
||||||
|
|
Loading…
Reference in New Issue