pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-07 06:17:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable no-useless-path-segments rule (#10860)

Browse Source
This commit is contained in:
Kamil Gabryjelski 2020-09-14 19:38:18 +02:00 committed by GitHub
parent 906a629b33
commit 7f1012360a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 14 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/.eslintrc.js
View File

@ -79,7 +79,6 @@ module.exports = {
], ],
'import/no-named-as-default': 0, 'import/no-named-as-default': 0,
'import/no-named-as-default-member': 0, 'import/no-named-as-default-member': 0,
'import/no-useless-path-segments': 0, // disabled temporarily
'import/prefer-default-export': 0, 'import/prefer-default-export': 0,
indent: 0, indent: 0,
'jsx-a11y/anchor-has-content': 0, 'jsx-a11y/anchor-has-content': 0,
@ -200,7 +199,6 @@ module.exports = {
], ],
'import/no-cycle': 0, // re-enable up for discussion, might require some major refactors 'import/no-cycle': 0, // re-enable up for discussion, might require some major refactors
'import/no-named-as-default': 0, 'import/no-named-as-default': 0,
'import/no-useless-path-segments': 0, // disabled temporarily
'import/prefer-default-export': 0, 'import/prefer-default-export': 0,
indent: 0, indent: 0,
'jsx-a11y/anchor-has-content': 0, 'jsx-a11y/anchor-has-content': 0,

2
superset-frontend/src/components/Icon/icon.stories.jsx
View File

@ -19,7 +19,7 @@
import React from 'react'; import React from 'react';
import { withKnobs, select } from '@storybook/addon-knobs'; import { withKnobs, select } from '@storybook/addon-knobs';
import { styled, supersetTheme } from '@superset-ui/core'; import { styled, supersetTheme } from '@superset-ui/core';
import Icon, { iconsRegistry } from './'; import Icon, { iconsRegistry } from '.';
export default { export default {
title: 'Icon', title: 'Icon',

2
superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx
View File

@ -24,7 +24,7 @@ import ChartImg from 'images/chart-card-fallback.png';
import { Dropdown, Menu } from 'src/common/components'; import { Dropdown, Menu } from 'src/common/components';
import Icon from 'src/components/Icon'; import Icon from 'src/components/Icon';
import FaveStar from 'src/components/FaveStar'; import FaveStar from 'src/components/FaveStar';
import ListViewCard from './'; import ListViewCard from '.';
export default { export default {
title: 'ListViewCard', title: 'ListViewCard',

2
superset-frontend/src/components/TableLoader.jsx
View File

@ -22,7 +22,7 @@ import { Table, Tr, Td } from 'reactable-arc';
import { t, SupersetClient } from '@superset-ui/core'; import { t, SupersetClient } from '@superset-ui/core';
import withToasts from '../messageToasts/enhancers/withToasts'; import withToasts from '../messageToasts/enhancers/withToasts';
import Loading from '../components/Loading'; import Loading from './Loading';
import '../../stylesheets/reactable-pagination.less'; import '../../stylesheets/reactable-pagination.less';
const propTypes = { const propTypes = {

6
superset-frontend/src/dashboard/actions/dashboardState.js
View File

@ -22,12 +22,12 @@ import { t, SupersetClient } from '@superset-ui/core';
import { addChart, removeChart, refreshChart } from '../../chart/chartAction'; import { addChart, removeChart, refreshChart } from '../../chart/chartAction';
import { chart as initChart } from '../../chart/chartReducer'; import { chart as initChart } from '../../chart/chartReducer';
import { fetchDatasourceMetadata } from '../../dashboard/actions/datasources'; import { fetchDatasourceMetadata } from './datasources';
import { import {
addFilter, addFilter,
removeFilter, removeFilter,
updateDirectPathToFilter, updateDirectPathToFilter,
} from '../../dashboard/actions/dashboardFilters'; } from './dashboardFilters';
import { applyDefaultFormData } from '../../explore/store'; import { applyDefaultFormData } from '../../explore/store';
import getClientErrorObject from '../../utils/getClientErrorObject'; import getClientErrorObject from '../../utils/getClientErrorObject';
import { SAVE_TYPE_OVERWRITE } from '../util/constants'; import { SAVE_TYPE_OVERWRITE } from '../util/constants';
@ -36,7 +36,7 @@ import {
addWarningToast, addWarningToast,
addDangerToast, addDangerToast,
} from '../../messageToasts/actions'; } from '../../messageToasts/actions';
import { UPDATE_COMPONENTS_PARENTS_LIST } from '../actions/dashboardLayout'; import { UPDATE_COMPONENTS_PARENTS_LIST } from './dashboardLayout';
import serializeActiveFilterValues from '../util/serializeActiveFilterValues'; import serializeActiveFilterValues from '../util/serializeActiveFilterValues';
import serializeFilterScopes from '../util/serializeFilterScopes'; import serializeFilterScopes from '../util/serializeFilterScopes';
import { getActiveFilters } from '../util/activeDashboardFilters'; import { getActiveFilters } from '../util/activeDashboardFilters';

2
superset-frontend/src/dashboard/reducers/index.js
View File

@ -24,7 +24,7 @@ import dashboardState from './dashboardState';
import dashboardFilters from './dashboardFilters'; import dashboardFilters from './dashboardFilters';
import datasources from './datasources'; import datasources from './datasources';
import sliceEntities from './sliceEntities'; import sliceEntities from './sliceEntities';
import dashboardLayout from '../reducers/undoableDashboardLayout'; import dashboardLayout from './undoableDashboardLayout';
import messageToasts from '../../messageToasts/reducers'; import messageToasts from '../../messageToasts/reducers';
const impressionId = (state = '') => state; const impressionId = (state = '') => state;

2
superset-frontend/src/dashboard/util/activeDashboardFilters.js
View File

@ -23,7 +23,7 @@ import {
getChartIdAndColumnFromFilterKey, getChartIdAndColumnFromFilterKey,
getDashboardFilterKey, getDashboardFilterKey,
} from './getDashboardFilterKey'; } from './getDashboardFilterKey';
import { CHART_TYPE } from '../util/componentTypes'; import { CHART_TYPE } from './componentTypes';
import { DASHBOARD_FILTER_SCOPE_GLOBAL } from '../reducers/dashboardFilters'; import { DASHBOARD_FILTER_SCOPE_GLOBAL } from '../reducers/dashboardFilters';
let allFilterBoxChartIds = []; let allFilterBoxChartIds = [];

6
superset-frontend/src/dashboard/util/getFilterScopeNodesTree.js
View File

@ -20,11 +20,7 @@ import { isEmpty } from 'lodash';
import { t } from '@superset-ui/core'; import { t } from '@superset-ui/core';
import { DASHBOARD_ROOT_ID } from './constants'; import { DASHBOARD_ROOT_ID } from './constants';
import { import { CHART_TYPE, DASHBOARD_ROOT_TYPE, TAB_TYPE } from './componentTypes';
CHART_TYPE,
DASHBOARD_ROOT_TYPE,
TAB_TYPE,
} from '../util/componentTypes';
const FILTER_SCOPE_CONTAINER_TYPES = [TAB_TYPE, DASHBOARD_ROOT_TYPE]; const FILTER_SCOPE_CONTAINER_TYPES = [TAB_TYPE, DASHBOARD_ROOT_TYPE];

4
superset-frontend/src/explore/components/DisplayQueryButton.jsx
View File

@ -40,11 +40,11 @@ import { t } from '@superset-ui/core';
import Button from 'src/components/Button'; import Button from 'src/components/Button';
import getClientErrorObject from '../../utils/getClientErrorObject'; import getClientErrorObject from '../../utils/getClientErrorObject';
import CopyToClipboard from './../../components/CopyToClipboard'; import CopyToClipboard from '../../components/CopyToClipboard';
import { getChartDataRequest } from '../../chart/chartAction'; import { getChartDataRequest } from '../../chart/chartAction';
import downloadAsImage from '../../utils/downloadAsImage'; import downloadAsImage from '../../utils/downloadAsImage';
import Loading from '../../components/Loading'; import Loading from '../../components/Loading';
import ModalTrigger from './../../components/ModalTrigger'; import ModalTrigger from '../../components/ModalTrigger';
import RowCountLabel from './RowCountLabel'; import RowCountLabel from './RowCountLabel';
import { import {
applyFormattingToTabularData, applyFormattingToTabularData,

2
superset-frontend/src/explore/components/ExploreViewContainer.jsx
View File

@ -35,7 +35,7 @@ import * as exploreActions from '../actions/exploreActions';
import * as saveModalActions from '../actions/saveModalActions'; import * as saveModalActions from '../actions/saveModalActions';
import * as chartActions from '../../chart/chartAction'; import * as chartActions from '../../chart/chartAction';
import { fetchDatasourceMetadata } from '../../dashboard/actions/datasources'; import { fetchDatasourceMetadata } from '../../dashboard/actions/datasources';
import * as logActions from '../../logger/actions/'; import * as logActions from '../../logger/actions';
import { import {
LOG_ACTIONS_MOUNT_EXPLORER, LOG_ACTIONS_MOUNT_EXPLORER,
LOG_ACTIONS_CHANGE_EXPLORE_CONTROLS, LOG_ACTIONS_CHANGE_EXPLORE_CONTROLS,

2
superset-frontend/src/explore/components/controls/CollectionControl.jsx
View File

@ -29,7 +29,7 @@ import {
import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls'; import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';
import ControlHeader from '../ControlHeader'; import ControlHeader from '../ControlHeader';
import controlMap from './'; import controlMap from '.';
import './CollectionControl.less'; import './CollectionControl.less';
const propTypes = { const propTypes = {

2
superset-frontend/src/explore/controlPanels/Shared_DeckGL.jsx
View File

@ -27,7 +27,7 @@ import {
columnChoices, columnChoices,
} from '@superset-ui/chart-controls'; } from '@superset-ui/chart-controls';
import { PRIMARY_COLOR } from '../controls'; import { PRIMARY_COLOR } from '../controls';
import { DEFAULT_VIEWPORT } from '../../explore/components/controls/ViewportControl'; import { DEFAULT_VIEWPORT } from '../components/controls/ViewportControl';
const sandboxUrl = const sandboxUrl =
'https://github.com/apache/incubator-superset/' + 'https://github.com/apache/incubator-superset/' +