pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-07 06:17:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: deprecate /superset/fetch_datasource_metadata mig to API v1 (#22102)

Browse Source
This commit is contained in:
Daniel Vaz Gaspar 2022-11-14 08:51:26 +00:00 committed by GitHub
parent 5b67e0712d
commit 7c6fabb033
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/src/SqlLab/actions/sqlLab.js
View File

@ -1409,17 +1409,18 @@ export function popQuery(queryId) {
}
export function popDatasourceQuery(datasourceKey, sql) {
return function (dispatch) {
const datasetId = datasourceKey.split('__')[0];
return SupersetClient.get({
endpoint: `/superset/fetch_datasource_metadata?datasourceKey=${datasourceKey}`,
endpoint: `/api/v1/dataset/${datasetId}?q=(keys:!(none))`,
})
.then(({ json }) =>
dispatch(
addQueryEditor({
name: `Query ${json.name}`,
dbId: json.database.id,
schema: json.schema,
name: `Query ${json.result.name}`,
dbId: json.result.database.id,
schema: json.result.schema,
autorun: sql !== undefined,
sql: sql || json.select_star,
sql: sql || json.result.select_star,
}),
),
)

1
superset/datasets/api.py
View File

@ -142,6 +142,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"cache_timeout",
"is_sqllab_view",
"template_params",
"select_star",
"owners.id",
"owners.username",
"owners.first_name",

5
superset/views/core.py
View File

@ -2598,6 +2598,11 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
:returns: The Flask response
:raises SupersetSecurityException: If the user cannot access the resource
"""
logger.warning(
"%s.fetch_datasource_metadata "
"This API endpoint is deprecated and will be removed in version 3.0.0",
self.__class__.__name__,
)
datasource_id, datasource_type = request.args["datasourceKey"].split("__")
datasource = DatasourceDAO.get_datasource(