pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane (#20969)

This commit is contained in:
EugeneTorap 2022-08-16 20:29:28 +03:00 committed by GitHub
parent d3684c0937
commit 6f3a555e58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx
View File

@ -41,8 +41,7 @@ export interface BCPProps {
const SUPERSET_HEADER_HEIGHT = 59; const SUPERSET_HEADER_HEIGHT = 59;
const SIDEPANE_ADJUST_OFFSET = 4; const SIDEPANE_ADJUST_OFFSET = 4;
const SIDEPANE_HEADER_HEIGHT = 64; // including margins const TOP_PANEL_OFFSET = 210;
const SIDEPANE_FILTERBAR_HEIGHT = 56;
const BuilderComponentPaneTabs = styled(Tabs)` const BuilderComponentPaneTabs = styled(Tabs)`
line-height: inherit; line-height: inherit;
@ -52,20 +51,10 @@ const BuilderComponentPaneTabs = styled(Tabs)`
const DashboardBuilderSidepane = styled.div<{ const DashboardBuilderSidepane = styled.div<{
topOffset: number; topOffset: number;
}>` }>`
height: 100%; height: calc(100% - ${TOP_PANEL_OFFSET}px);
position: fixed; position: fixed;
right: 0; right: 0;
top: 0; top: 0;
.ReactVirtualized__List {
padding-bottom: ${({ topOffset }) =>
`${
SIDEPANE_HEADER_HEIGHT +
SIDEPANE_FILTERBAR_HEIGHT +
SIDEPANE_ADJUST_OFFSET +
topOffset
}px`};
}
`; `;
const BuilderComponentPane: React.FC<BCPProps> = ({ const BuilderComponentPane: React.FC<BCPProps> = ({