mirror of https://github.com/apache/superset.git
feat: Configurable default row limit for native filters (#24043)
Co-authored-by: Calum Leslie <calum.leslie@skyscanner.net>
This commit is contained in:
parent
cd78ccb2c2
commit
6f25275d76
|
@ -33,6 +33,14 @@ import extractUrlParams from 'src/dashboard/util/extractUrlParams';
|
||||||
import { isFeatureEnabled } from 'src/featureFlags';
|
import { isFeatureEnabled } from 'src/featureFlags';
|
||||||
import { CHART_TYPE, TAB_TYPE } from '../../util/componentTypes';
|
import { CHART_TYPE, TAB_TYPE } from '../../util/componentTypes';
|
||||||
import { DASHBOARD_GRID_ID, DASHBOARD_ROOT_ID } from '../../util/constants';
|
import { DASHBOARD_GRID_ID, DASHBOARD_ROOT_ID } from '../../util/constants';
|
||||||
|
import getBootstrapData from '../../../utils/getBootstrapData';
|
||||||
|
|
||||||
|
const getDefaultRowLimit = (): number => {
|
||||||
|
const bootstrapData = getBootstrapData();
|
||||||
|
const nativeFilterDefaultRowLimit =
|
||||||
|
bootstrapData?.common?.conf?.NATIVE_FILTER_DEFAULT_ROW_LIMIT;
|
||||||
|
return nativeFilterDefaultRowLimit || 1000;
|
||||||
|
};
|
||||||
|
|
||||||
export const getFormData = ({
|
export const getFormData = ({
|
||||||
datasetId,
|
datasetId,
|
||||||
|
@ -75,7 +83,7 @@ export const getFormData = ({
|
||||||
extra_form_data: dependencies,
|
extra_form_data: dependencies,
|
||||||
granularity_sqla,
|
granularity_sqla,
|
||||||
metrics: ['count'],
|
metrics: ['count'],
|
||||||
row_limit: 1000,
|
row_limit: getDefaultRowLimit(),
|
||||||
showSearch: true,
|
showSearch: true,
|
||||||
defaultValue: defaultDataMask?.filterState?.value,
|
defaultValue: defaultDataMask?.filterState?.value,
|
||||||
time_range,
|
time_range,
|
||||||
|
|
|
@ -146,6 +146,8 @@ DEFAULT_VIZ_TYPE = "table"
|
||||||
ROW_LIMIT = 50000
|
ROW_LIMIT = 50000
|
||||||
# default row limit when requesting samples from datasource in explore view
|
# default row limit when requesting samples from datasource in explore view
|
||||||
SAMPLES_ROW_LIMIT = 1000
|
SAMPLES_ROW_LIMIT = 1000
|
||||||
|
# default row limit for native filters
|
||||||
|
NATIVE_FILTER_DEFAULT_ROW_LIMIT = 1000
|
||||||
# max rows retrieved by filter select auto complete
|
# max rows retrieved by filter select auto complete
|
||||||
FILTER_SELECT_ROW_LIMIT = 10000
|
FILTER_SELECT_ROW_LIMIT = 10000
|
||||||
# default time filter in explore
|
# default time filter in explore
|
||||||
|
|
|
@ -120,6 +120,7 @@ FRONTEND_CONF_KEYS = (
|
||||||
"ALERT_REPORTS_DEFAULT_CRON_VALUE",
|
"ALERT_REPORTS_DEFAULT_CRON_VALUE",
|
||||||
"ALERT_REPORTS_DEFAULT_RETENTION",
|
"ALERT_REPORTS_DEFAULT_RETENTION",
|
||||||
"ALERT_REPORTS_DEFAULT_WORKING_TIMEOUT",
|
"ALERT_REPORTS_DEFAULT_WORKING_TIMEOUT",
|
||||||
|
"NATIVE_FILTER_DEFAULT_ROW_LIMIT",
|
||||||
)
|
)
|
||||||
|
|
||||||
logger = logging.getLogger(__name__)
|
logger = logging.getLogger(__name__)
|
||||||
|
|
Loading…
Reference in New Issue