pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-19 20:19:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(legacy-plugin-chart-table): parse numeric pageLength (#522)

Browse Source
This commit is contained in:
Jesse Yang 2020-05-21 16:42:50 -07:00 committed by Yongjie Zhao
parent 8776262499
commit 6d04279daf
3 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-table/src/transformProps.ts
View File

@ -138,7 +138,7 @@ export default function transformProps(chartProps: TableChartProps): DataTablePr
showCellBars,
includeSearch,
orderDesc,
pageLength: typeof pageLength === 'string' ? parseInt(pageLength, 10) || 0 : 0,
pageLength: typeof pageLength === 'string' ? parseInt(pageLength, 10) || 0 : pageLength,
tableTimestampFormat,
filters,
emitFilter: tableFilter === true,

18
superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-table/test/ReactDataTable.test.tsx
View File

@ -24,7 +24,23 @@ import testData from './testData';
describe('legacy-table', () => {
// Can test more prop transformation here. Not needed for now.
describe('transformProps', () => {});
describe('transformProps', () => {
it('should parse pageLength', () => {
expect(transformProps(testData.basic).pageLength).toBe(20);
expect(
transformProps({
...testData.basic,
formData: { ...testData.basic.formData, pageLength: '20' },
}).pageLength,
).toBe(20);
expect(
transformProps({
...testData.basic,
formData: { ...testData.basic.formData, pageLength: '' },
}).pageLength,
).toBe(0);
});
});
describe('ReactDataTable', () => {
let wrap: CommonWrapper; // the ReactDataTable wraper

2
superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-table/test/testData.ts
View File

@ -26,7 +26,7 @@ const basicFormData = {
showCellBars: true,
includeSearch: false,
orderDesc: true,
pageLength: 0,
pageLength: 20,
metrics: [],
percentMetrics: null,
timeseriesLimitMetric: null,