fix: Workaround for Pandas.DataFrame.to_csv bug (#28755)

This commit is contained in:
John Bodley 2024-06-13 08:54:54 -07:00 committed by GitHub
parent 31afb62e95
commit 6b016da185
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 15 deletions

View File

@ -78,7 +78,7 @@ def df_to_escaped_csv(df: pd.DataFrame, **kwargs: Any) -> Any:
if isinstance(value, str):
df.at[idx, name] = escape_value(value)
return df.to_csv(**kwargs)
return df.to_csv(escapechar="\\", **kwargs)
def get_chart_csv_data(

View File

@ -14,7 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import io
import pandas as pd
import pyarrow as pa
@ -59,24 +58,39 @@ def test_escape_value():
def test_df_to_escaped_csv():
csv_rows = [
["col_a", "=func()"],
["-10", "=cmd|' /C calc'!A0"],
["a", '""=b'],
[" =a", "b"],
]
csv_str = "\n".join([",".join(row) for row in csv_rows])
df = pd.DataFrame(
data={
"value": [
"a",
"col_a",
"=func()",
"-10",
"=cmd|' /C calc'!A0",
'""=b',
" =a",
"\x00",
]
}
)
df = pd.read_csv(io.StringIO(csv_str))
escaped_csv_str = csv.df_to_escaped_csv(
df,
encoding="utf8",
index=False,
header=False,
)
escaped_csv_str = csv.df_to_escaped_csv(df, encoding="utf8", index=False)
escaped_csv_rows = [row.split(",") for row in escaped_csv_str.strip().split("\n")]
assert escaped_csv_rows == [
["col_a", "'=func()"],
["-10", r"'=cmd\|' /C calc'!A0"],
["a", "'=b"], # pandas seems to be removing the leading ""
["' =a", "b"],
["a"],
["col_a"],
["'=func()"],
["-10"],
[r"'=cmd\\|' /C calc'!A0"],
['"\'""""=b"'],
["' =a"],
["\x00"],
]
df = pa.array([1, None]).to_pandas(integer_object_nulls=True).to_frame()