pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(plugin-chart-echarts): boxplot throw error in the dashboard (#21661)

This commit is contained in:
Stephen Liu 2022-10-01 08:53:29 +08:00 committed by GitHub
parent 4c17f0e71e
commit 61bd696226
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
View File

@ -359,7 +359,7 @@ const show_empty_columns: SharedControlConfig<'CheckboxControl'> = {
const datetime_columns_lookup: SharedControlConfig<'HiddenControl'> = { const datetime_columns_lookup: SharedControlConfig<'HiddenControl'> = {
type: 'HiddenControl', type: 'HiddenControl',
initialValue: (control: ControlState, state: ControlPanelState) => initialValue: (control: ControlState, state: ControlPanelState | null) =>
Object.fromEntries( Object.fromEntries(
ensureIsArray<Record<string, any>>(state?.datasource?.columns) ensureIsArray<Record<string, any>>(state?.datasource?.columns)
.filter(option => option.is_dttm) .filter(option => option.is_dttm)

2
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/mixins.tsx
View File

@ -39,7 +39,7 @@ export const xAxisMixin = {
description: (state: ControlPanelState) => description: (state: ControlPanelState) =>
getAxisLabel(state?.form_data).description, getAxisLabel(state?.form_data).description,
validators: [validateNonEmpty], validators: [validateNonEmpty],
initialValue: (control: ControlState, state: ControlPanelState) => { initialValue: (control: ControlState, state: ControlPanelState | null) => {
if ( if (
isFeatureEnabled(FeatureFlag.GENERIC_CHART_AXES) && isFeatureEnabled(FeatureFlag.GENERIC_CHART_AXES) &&
state?.form_data?.granularity_sqla && state?.form_data?.granularity_sqla &&

10
superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts
View File

@ -172,10 +172,14 @@ const config: ControlPanelConfig = {
label: t('Distribute across'), label: t('Distribute across'),
multi: true, multi: true,
description: t('Columns to calculate distribution across.'), description: t('Columns to calculate distribution across.'),
initialValue: (control: ControlState, state: ControlPanelState) => { initialValue: (
control: ControlState,
state: ControlPanelState | null,
) => {
if ( if (
(state && !control?.value) || state &&
(Array.isArray(control?.value) && control.value.length === 0) (!control?.value ||
(Array.isArray(control?.value) && control.value.length === 0))
) { ) {
return [getTemporalColumns(state.datasource).defaultTemporalColumn]; return [getTemporalColumns(state.datasource).defaultTemporalColumn];
} }