pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Adds a tooltip for the alert's SQL input (#26317)

This commit is contained in:
Michael S. Molina 2023-12-22 08:32:59 -03:00 committed by GitHub
parent 5e85f5c81f
commit 5bd7fd7990
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
superset-frontend/src/features/alerts/AlertReportModal.tsx
View File

@ -152,6 +152,10 @@ const StyledModal = styled(Modal)`
}
`;
const StyledTooltip = styled(InfoTooltipWithTrigger)`
margin-left: ${({ theme }) => theme.gridUnit}px;
`;
const StyledIcon = (theme: SupersetTheme) => css`
margin: auto ${theme.gridUnit * 2}px auto 0;
color: ${theme.colors.grayscale.base};
@ -397,10 +401,12 @@ export const TRANSLATIONS = {
ALERT_CONDITION_TEXT: t('Alert condition'),
DATABASE_TEXT: t('Database'),
SQL_QUERY_TEXT: t('SQL Query'),
SQL_QUERY_TOOLTIP: t(
'The result of this query should be a numeric-esque value',
),
TRIGGER_ALERT_IF_TEXT: t('Trigger Alert If...'),
CONDITION_TEXT: t('Condition'),
VALUE_TEXT: t('Value'),
VALUE_TOOLTIP: t('Threshold value should be double precision number'),
REPORT_SCHEDULE_TEXT: t('Report schedule'),
ALERT_CONDITION_SCHEDULE_TEXT: t('Alert condition schedule'),
TIMEZONE_TEXT: t('Timezone'),
@ -1284,6 +1290,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
<StyledInputContainer>
<div className="control-label">
{TRANSLATIONS.SQL_QUERY_TEXT}
<StyledTooltip tooltip={TRANSLATIONS.SQL_QUERY_TOOLTIP} />
<span className="required">*</span>
</div>
<TextAreaControl
@ -1319,10 +1326,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
</StyledInputContainer>
<StyledInputContainer>
<div className="control-label">
{TRANSLATIONS.VALUE_TEXT}{' '}
<InfoTooltipWithTrigger
tooltip={TRANSLATIONS.VALUE_TOOLTIP}
/>
{TRANSLATIONS.VALUE_TEXT}
<span className="required">*</span>
</div>
<div className="input-container">