pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 08:39:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Show cross filter option only when cross filter is enabled (#16391)

Browse Source
This commit is contained in:
Michael S. Molina 2021-08-24 09:13:39 -03:00 committed by GitHub
parent 9a37ad1a1e
commit 575e7af859
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
View File

@ -88,6 +88,7 @@ export interface SliceHeaderControlsProps {
slice_name: string; slice_name: string;
slice_id: number; slice_id: number;
slice_description: string; slice_description: string;
form_data?: { emit_filter?: boolean };
}; };
componentId: string; componentId: string;
@ -229,6 +230,7 @@ class SliceHeaderControls extends React.PureComponent<
value.behaviors?.includes(Behavior.INTERACTIVE_CHART), value.behaviors?.includes(Behavior.INTERACTIVE_CHART),
) )
.find(([key]) => key === slice.viz_type); .find(([key]) => key === slice.viz_type);
const canEmitCrossFilter = slice.form_data?.emit_filter;
const cachedWhen = (cachedDttm || []).map(itemCachedDttm => const cachedWhen = (cachedDttm || []).map(itemCachedDttm =>
moment.utc(itemCachedDttm).fromNow(), moment.utc(itemCachedDttm).fromNow(),
@ -335,7 +337,8 @@ class SliceHeaderControls extends React.PureComponent<
</Menu.Item> </Menu.Item>
)} )}
{isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) && {isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) &&
isCrossFilter && ( isCrossFilter &&
canEmitCrossFilter && (
<Menu.Item key={MENU_KEYS.CROSS_FILTER_SCOPING}> <Menu.Item key={MENU_KEYS.CROSS_FILTER_SCOPING}>
{t('Cross-filter scoping')} {t('Cross-filter scoping')}
</Menu.Item> </Menu.Item>