mirror of
https://github.com/apache/superset.git
synced 2024-09-06 22:07:34 -04:00
chore: add missing keys to components inside lists (#19161)
This commit is contained in:
parent
d771ddbb94
commit
54f1b35161
@ -143,6 +143,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
|
||||
optionSelector.values.map((column, idx) =>
|
||||
isFeatureEnabled(FeatureFlag.ENABLE_DND_WITH_CLICK_UX) ? (
|
||||
<ColumnSelectPopoverTrigger
|
||||
key={idx}
|
||||
columns={popoverOptions}
|
||||
onColumnEdit={newColumn => {
|
||||
if (isColumnMeta(newColumn)) {
|
||||
|
@ -134,8 +134,13 @@ const WelcomeNav = styled.div`
|
||||
|
||||
export const LoadingCards = ({ cover }: LoadingProps) => (
|
||||
<CardContainer showThumbnails={cover} className="loading-cards">
|
||||
{[...new Array(loadingCardCount)].map(() => (
|
||||
<ListViewCard cover={cover ? false : <></>} description="" loading />
|
||||
{[...new Array(loadingCardCount)].map((_, index) => (
|
||||
<ListViewCard
|
||||
key={index}
|
||||
cover={cover ? false : <></>}
|
||||
description=""
|
||||
loading
|
||||
/>
|
||||
))}
|
||||
</CardContainer>
|
||||
);
|
||||
|
@ -205,7 +205,7 @@ export function Menu({
|
||||
}: MenuProps) {
|
||||
const [showMenu, setMenu] = useState<MenuMode>('horizontal');
|
||||
const screens = useBreakpoint();
|
||||
const uiConig = useUiConfig();
|
||||
const uiConfig = useUiConfig();
|
||||
const theme = useTheme();
|
||||
|
||||
useEffect(() => {
|
||||
@ -221,7 +221,7 @@ export function Menu({
|
||||
}, []);
|
||||
|
||||
const standalone = getUrlParam(URL_PARAMS.standalone);
|
||||
if (standalone || uiConig.hideNav) return <></>;
|
||||
if (standalone || uiConfig.hideNav) return <></>;
|
||||
|
||||
const renderSubMenu = ({
|
||||
label,
|
||||
@ -297,8 +297,9 @@ export function Menu({
|
||||
data-test="navbar-top"
|
||||
className="main-nav"
|
||||
>
|
||||
{menu.map(item => {
|
||||
{menu.map((item, index) => {
|
||||
const props = {
|
||||
index,
|
||||
...item,
|
||||
isFrontendRoute: isFrontendRoute(item.url),
|
||||
childs: item.childs?.map(c => {
|
||||
|
@ -16,7 +16,7 @@
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
import React, { useState } from 'react';
|
||||
import React, { Fragment, useState } from 'react';
|
||||
import { MainNav as Menu } from 'src/components/Menu';
|
||||
import { t, styled, css, SupersetTheme } from '@superset-ui/core';
|
||||
import { Link } from 'react-router-dom';
|
||||
@ -195,22 +195,22 @@ const RightMenu = ({
|
||||
if (menu.childs) {
|
||||
return canDatabase || canUpload ? (
|
||||
<SubMenu
|
||||
key="sub2"
|
||||
key={`sub2_${menu.label}`}
|
||||
className="data-menu"
|
||||
title={menuIconAndLabel(menu)}
|
||||
>
|
||||
{menu.childs.map((item, idx) =>
|
||||
typeof item !== 'string' && item.name && item.perm ? (
|
||||
<>
|
||||
<Fragment key={item.name}>
|
||||
{idx === 2 && <Menu.Divider />}
|
||||
<Menu.Item key={item.name}>
|
||||
<Menu.Item>
|
||||
{item.url ? (
|
||||
<a href={item.url}> {item.label} </a>
|
||||
) : (
|
||||
item.label
|
||||
)}
|
||||
</Menu.Item>
|
||||
</>
|
||||
</Fragment>
|
||||
) : null,
|
||||
)}
|
||||
</SubMenu>
|
||||
@ -257,7 +257,9 @@ const RightMenu = ({
|
||||
return null;
|
||||
})}
|
||||
</Menu.ItemGroup>,
|
||||
index < settings.length - 1 && <Menu.Divider />,
|
||||
index < settings.length - 1 && (
|
||||
<Menu.Divider key={`divider_${index}`} />
|
||||
),
|
||||
])}
|
||||
|
||||
{!navbarRight.user_is_anonymous && [
|
||||
|
Loading…
Reference in New Issue
Block a user