pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Persist query params appended to permalink (#27601)

This commit is contained in:
Kamil Gabryjelski 2024-03-22 10:24:31 +01:00 committed by GitHub
parent 8a715cc1b5
commit 5083ca0e81
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/views/core.py
View File

@ -843,6 +843,8 @@ class Superset(BaseSupersetView):
if url_params := state.get("urlParams"):
params = parse.urlencode(url_params)
url = f"{url}&{params}"
if original_params := request.query_string.decode():
url = f"{url}&{original_params}"
if hash_ := state.get("anchor", state.get("hash")):
url = f"{url}#{hash_}"
return redirect(url)

15
tests/integration_tests/core_tests.py
View File

@ -1208,6 +1208,21 @@ class TestCore(SupersetTestCase):
is True
)
@mock.patch("superset.views.core.request")
@mock.patch(
"superset.commands.dashboard.permalink.get.GetDashboardPermalinkCommand.run"
)
def test_dashboard_permalink(self, get_dashboard_permalink_mock, request_mock):
request_mock.query_string = b"standalone=3"
get_dashboard_permalink_mock.return_value = {"dashboardId": 1}
self.login()
resp = self.client.get("superset/dashboard/p/123/")
expected_url = "/superset/dashboard/1?permalink_key=123&standalone=3"
self.assertEqual(resp.headers["Location"], expected_url)
assert resp.status_code == 302
if __name__ == "__main__":
unittest.main()