pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 08:39:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(DB Connection): Update placeholder values for Snowflake connection (#25119)

Browse Source
This commit is contained in:
Vitor Avila 2023-08-30 09:16:31 -03:00 committed by GitHub
parent 00550d7c02
commit 46a0a6e08a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx
View File

@ -24,9 +24,9 @@ import { FieldPropTypes } from '.';
const FIELD_TEXT_MAP = { const FIELD_TEXT_MAP = {
account: { account: {
helpText: t( helpText: t(
'Copy the account name of that database you are trying to connect to.', 'Copy the identifier of the account you are trying to connect to.',
), ),
placeholder: t('e.g. world_population'), placeholder: t('e.g. xy12345.us-east-2.aws'),
}, },
warehouse: { warehouse: {
placeholder: t('e.g. compute_wh'), placeholder: t('e.g. compute_wh'),

7
superset-frontend/src/features/databases/DatabaseModal/index.tsx
View File

@ -667,12 +667,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
const getPlaceholder = (field: string) => { const getPlaceholder = (field: string) => {
if (field === 'database') { if (field === 'database') {
switch (db?.engine) { return t('e.g. world_population');
case Engines.Snowflake:
return t('e.g. xy12345.us-east-2.aws');
default:
return t('e.g. world_population');
}
} }
return undefined; return undefined;
}; };