fix: small fixes for Makefile (#15670)

This commit is contained in:
Beto Dealmeida 2021-07-13 15:45:23 -07:00 committed by GitHub
parent 9f969d00bd
commit 42a1061bfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions

View File

@ -15,6 +15,9 @@
# limitations under the License. # limitations under the License.
# #
# Python version installed; we need 3.8 or 3.7
PYTHON=`command -v python3.8 || command -v python3.7`
.PHONY: install superset venv pre-commit .PHONY: install superset venv pre-commit
install: superset pre-commit install: superset pre-commit
@ -59,8 +62,9 @@ update-js:
venv: venv:
# Create a virtual environment and activate it (recommended) # Create a virtual environment and activate it (recommended)
python3 -m venv venv # setup a python3 virtualenv if ! [ -x "${PYTHON}" ]; then echo "You need Python 3.7 or 3.8 installed"; exit 1; fi
source venv/bin/activate test -d venv || ${PYTHON} -m venv venv # setup a python3 virtualenv
. venv/bin/activate
pre-commit: pre-commit:
# setup pre commit dependencies # setup pre commit dependencies