pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(alerts/reports): misconfigured useEffect hook breaks form validation in prod builds (#12779)

This commit is contained in:
ʈᵃᵢ 2021-01-26 13:44:15 -08:00 committed by GitHub
parent 017f11f9d8
commit 3ed915146d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
View File

@ -992,27 +992,23 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
}, [resource]); }, [resource]);
// Validation // Validation
useEffect( const currentAlertSafe = currentAlert || {};
() => { useEffect(() => {
validate(); validate();
}, }, [
currentAlert currentAlertSafe.name,
? [ currentAlertSafe.owners,
currentAlert.name, currentAlertSafe.database,
currentAlert.owners, currentAlertSafe.sql,
currentAlert.database, currentAlertSafe.validator_config_json,
currentAlert.sql, currentAlertSafe.crontab,
currentAlert.validator_config_json, currentAlertSafe.working_timeout,
currentAlert.crontab, currentAlertSafe.dashboard,
currentAlert.working_timeout, currentAlertSafe.chart,
currentAlert.dashboard,
currentAlert.chart,
contentType, contentType,
notificationSettings, notificationSettings,
conditionNotNull, conditionNotNull,
] ]);
: [],
);
// Show/hide // Show/hide
if (isHidden && show) { if (isHidden && show) {