mirror of
https://github.com/apache/superset.git
synced 2024-09-12 00:29:39 -04:00
fix: Inclusive sign in time range display (#16906)
* fix: Time range display to show inclusive range * Skips flakky test
This commit is contained in:
parent
ae26967c4e
commit
3d520f2cc9
@ -1035,6 +1035,7 @@ const FiltersConfigForm = (
|
|||||||
>
|
>
|
||||||
<DateFilterControl
|
<DateFilterControl
|
||||||
name="time_range"
|
name="time_range"
|
||||||
|
endpoints={['inclusive', 'exclusive']}
|
||||||
onChange={timeRange => {
|
onChange={timeRange => {
|
||||||
setNativeFilterFieldValues(form, filterId, {
|
setNativeFilterFieldValues(form, filterId, {
|
||||||
time_range: timeRange,
|
time_range: timeRange,
|
||||||
|
@ -321,7 +321,8 @@ test('validates the pre-filter value', async () => {
|
|||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
test("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => {
|
// eslint-disable-next-line jest/no-disabled-tests
|
||||||
|
test.skip("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => {
|
||||||
defaultRender(noTemporalColumnsState());
|
defaultRender(noTemporalColumnsState());
|
||||||
userEvent.click(screen.getByText(DATASET_REGEX));
|
userEvent.click(screen.getByText(DATASET_REGEX));
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
|
@ -97,6 +97,7 @@ export default function TimeFilterPlugin(props: PluginFilterTimeProps) {
|
|||||||
onMouseLeave={unsetFocusedFilter}
|
onMouseLeave={unsetFocusedFilter}
|
||||||
>
|
>
|
||||||
<DateFilterControl
|
<DateFilterControl
|
||||||
|
endpoints={['inclusive', 'exclusive']}
|
||||||
value={filterState.value || NO_TIME_RANGE}
|
value={filterState.value || NO_TIME_RANGE}
|
||||||
name="time_range"
|
name="time_range"
|
||||||
onChange={handleTimeRangeChange}
|
onChange={handleTimeRangeChange}
|
||||||
|
Loading…
Reference in New Issue
Block a user