pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge a995f08def into f5843fe588

This commit is contained in:
Sam Firke 2024-05-05 02:18:23 -03:00 committed by GitHub
parent f5843fe588 a995f08def
commit 3b07cc4c31
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
View File

@ -187,13 +187,13 @@ describe('Drill to detail modal', () => {
cy.on('uncaught:exception', () => false);
cy.wait('@samples');
cy.get('.virtual-table-cell').should($rows => {
expect($rows).to.contain('Kelly');
expect($rows).to.contain('Kimberly');
});
// verify scroll top on pagination
cy.getBySelLike('Number-modal').find('.virtual-grid').scrollTo(0, 200);
cy.get('.virtual-grid').contains('Juan').should('not.be.visible');
cy.get('.virtual-grid').contains('Kim').should('not.be.visible');
cy.get('.ant-pagination-item').eq(0).click();

2
superset/common/query_actions.py
View File

@ -170,7 +170,6 @@ def _get_drill_detail(
datasource = _get_datasource(query_context, query_obj)
query_obj = copy.copy(query_obj)
query_obj.is_timeseries = False
query_obj.orderby = []
query_obj.metrics = None
query_obj.post_processing = []
qry_obj_cols = []
@ -180,6 +179,7 @@ def _get_drill_detail(
else:
qry_obj_cols.append(o.column_name)
query_obj.columns = qry_obj_cols
query_obj.orderby = [(query_obj.columns[0], True)]
return _get_full(query_context, query_obj, force_cached)

2
superset/superset_typing.py
View File

@ -105,7 +105,7 @@ FormData = dict[str, Any]
Granularity = Union[str, dict[str, Union[str, float]]]
Column = Union[AdhocColumn, str]
Metric = Union[AdhocMetric, str]
OrderBy = tuple[Metric, bool]
OrderBy = tuple[Union[Metric, Column], bool]
QueryObjectDict = dict[str, Any]
VizData = Optional[Union[list[Any], dict[Any, Any]]]
VizPayload = dict[str, Any]