pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 00:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

[schema] Adding commits and removing unnecessary foreign-key definitions (#7371)

Browse Source
This commit is contained in:
John Bodley 2019-04-24 12:33:33 -07:00 committed by GitHub
parent 7bc8355b75
commit 3a359fd892
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
superset/migrations/versions/7f2635b51f5d_update_base_columns.py
View File

@ -30,7 +30,7 @@ revision = '7f2635b51f5d'
down_revision = '937d04c16b64' down_revision = '937d04c16b64'
from alembic import op from alembic import op
from sqlalchemy import Column, engine, ForeignKey, Integer, String from sqlalchemy import Column, engine, Integer, String
from sqlalchemy.ext.declarative import declarative_base from sqlalchemy.ext.declarative import declarative_base
from superset import db from superset import db
@ -43,20 +43,20 @@ conv = {
} }
class BaseColumnMixin(object): class BaseColumnMixin:
id = Column(Integer, primary_key=True) id = Column(Integer, primary_key=True)
class DruidColumn(BaseColumnMixin, Base): class DruidColumn(BaseColumnMixin, Base):
__tablename__ = 'columns' __tablename__ = 'columns'
datasource_id = Column(Integer, ForeignKey('datasources.id')) datasource_id = Column(Integer)
class TableColumn(BaseColumnMixin, Base): class TableColumn(BaseColumnMixin, Base):
__tablename__ = 'table_columns' __tablename__ = 'table_columns'
table_id = Column(Integer, ForeignKey('tables.id')) table_id = Column(Integer)
def upgrade(): def upgrade():
@ -68,7 +68,9 @@ def upgrade():
if record.datasource_id is None: if record.datasource_id is None:
session.delete(record) session.delete(record)
# Enforce that the columns.column_name be non-nullable. session.commit()
# Enforce that the columns.column_name column be non-nullable.
with op.batch_alter_table('columns') as batch_op: with op.batch_alter_table('columns') as batch_op:
batch_op.alter_column( batch_op.alter_column(
'column_name', 'column_name',
@ -81,6 +83,8 @@ def upgrade():
if record.table_id is None: if record.table_id is None:
session.delete(record) session.delete(record)
session.commit()
# Reduce the size of the table_columns.column_name column for constraint # Reduce the size of the table_columns.column_name column for constraint
# viability and enforce that it be non-nullable. # viability and enforce that it be non-nullable.
with op.batch_alter_table('table_columns') as batch_op: with op.batch_alter_table('table_columns') as batch_op: