chore: improve performance on bootstrap permissions (#22083)

This commit is contained in:
Daniel Vaz Gaspar 2022-11-10 21:47:55 +00:00 committed by GitHub
parent 95b4c7b7fe
commit 35e0e5bfe6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 14 deletions

View File

@ -76,7 +76,7 @@ flask==2.0.3
# flask-migrate
# flask-sqlalchemy
# flask-wtf
flask-appbuilder==4.1.4
flask-appbuilder==4.1.6
# via apache-superset
flask-babel==1.0.0
# via flask-appbuilder

View File

@ -83,7 +83,7 @@ setup(
"cryptography>=3.3.2",
"deprecation>=2.1.0, <2.2.0",
"flask>=2.0.0, <3.0.0",
"flask-appbuilder>=4.1.4, <5.0.0",
"flask-appbuilder>=4.1.6, <5.0.0",
"flask-caching>=1.10.0",
"flask-compress",
"flask-talisman",

View File

@ -103,23 +103,20 @@ def bootstrap_user_data(user: User, include_perms: bool = False) -> Dict[str, An
def get_permissions(
user: User,
) -> Tuple[Dict[str, List[List[str]]], DefaultDict[str, List[str]]]:
) -> Tuple[Dict[str, List[Tuple[str]]], DefaultDict[str, List[str]]]:
if not user.roles:
raise AttributeError("User object does not have roles")
roles = defaultdict(list)
permissions = defaultdict(set)
for role in user.roles:
permissions_ = security_manager.get_role_permissions(role)
for permission in permissions_:
data_permissions = defaultdict(set)
roles_permissions = security_manager.get_user_roles_permissions(user)
for _, permissions in roles_permissions.items():
for permission in permissions:
if permission[0] in ("datasource_access", "database_access"):
permissions[permission[0]].add(permission[1])
roles[role.name].append([permission[0], permission[1]])
data_permissions[permission[0]].add(permission[1])
transformed_permissions = defaultdict(list)
for perm in permissions:
transformed_permissions[perm] = list(permissions[perm])
return roles, transformed_permissions
for perm in data_permissions:
transformed_permissions[perm] = list(data_permissions[perm])
return roles_permissions, transformed_permissions
def get_viz(