mirror of https://github.com/apache/superset.git
fix: Disable filtering on wide result sets (#18021)
This commit is contained in:
parent
14b9298ef7
commit
343d3f8f7a
|
@ -37,7 +37,9 @@ import { SaveDatasetModal } from 'src/SqlLab/components/SaveDatasetModal';
|
||||||
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
|
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
|
||||||
import ProgressBar from 'src/components/ProgressBar';
|
import ProgressBar from 'src/components/ProgressBar';
|
||||||
import Loading from 'src/components/Loading';
|
import Loading from 'src/components/Loading';
|
||||||
import FilterableTable from 'src/components/FilterableTable/FilterableTable';
|
import FilterableTable, {
|
||||||
|
MAX_COLUMNS_FOR_TABLE,
|
||||||
|
} from 'src/components/FilterableTable/FilterableTable';
|
||||||
import CopyToClipboard from 'src/components/CopyToClipboard';
|
import CopyToClipboard from 'src/components/CopyToClipboard';
|
||||||
import { prepareCopyToClipboardTabularData } from 'src/utils/common';
|
import { prepareCopyToClipboardTabularData } from 'src/utils/common';
|
||||||
import { exploreChart } from 'src/explore/exploreUtils';
|
import { exploreChart } from 'src/explore/exploreUtils';
|
||||||
|
@ -560,7 +562,12 @@ export default class ResultSet extends React.PureComponent<
|
||||||
onChange={this.changeSearch}
|
onChange={this.changeSearch}
|
||||||
value={this.state.searchText}
|
value={this.state.searchText}
|
||||||
className="form-control input-sm"
|
className="form-control input-sm"
|
||||||
placeholder={t('Filter results')}
|
disabled={columns.length > MAX_COLUMNS_FOR_TABLE}
|
||||||
|
placeholder={
|
||||||
|
columns.length > MAX_COLUMNS_FOR_TABLE
|
||||||
|
? t('Too many columns to filter')
|
||||||
|
: t('Filter results')
|
||||||
|
}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</ResultSetControls>
|
</ResultSetControls>
|
||||||
|
|
Loading…
Reference in New Issue