pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 05:47:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore(dashboard): Add filter_scopes warning message for json metadata editor (#21543)

Browse Source 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
This commit is contained in:
JUST.in DO IT 2022-09-26 15:05:41 -07:00 committed by GitHub
parent 954fc89871
commit 2cdd88aa4f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
View File

@ -36,6 +36,7 @@ import Modal from 'src/components/Modal';
import { JsonEditor } from 'src/components/AsyncAceEditor';
import ColorSchemeControlWrapper from 'src/dashboard/components/ColorSchemeControlWrapper';
import FilterScopeModal from 'src/dashboard/components/filterscope/FilterScopeModal';
import { getClientErrorObject } from 'src/utils/getClientErrorObject';
import withToasts from 'src/components/MessageToasts/withToasts';
import { FeatureFlag, isFeatureEnabled } from 'src/featureFlags';
@ -658,6 +659,23 @@ const PropertiesModal = ({
{t(
'This JSON object is generated dynamically when clicking the save or overwrite button in the dashboard view. It is exposed here for reference and for power users who may want to alter specific parameters.',
)}
{onlyApply && (
<>
{' '}
{t(
'Please DO NOT overwrite the "filter_scopes" key.',
)}{' '}
<FilterScopeModal
triggerNode={
<span className="alert-link">
{t('Use "%(menuName)s" menu instead.', {
menuName: t('Set filter mapping'),
})}
</span>
}
/>
</>
)}
</p>
</>
)}

5
superset-frontend/src/views/routes.test.tsx
View File

@ -16,13 +16,16 @@
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { isFrontendRoute, routes } from './routes';
jest.mock('src/featureFlags', () => ({
...jest.requireActual<object>('src/featureFlags'),
isFeatureEnabled: jest.fn().mockReturnValue(true),
}));
jest.mock('src/views/CRUD/welcome/Welcome', () => () => (
<div data-test="mock-welcome" />
));
describe('isFrontendRoute', () => {
it('returns true if a route matches', () => {