pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-16 02:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

Reviewed and repaired disabled pylint in dashboard file (#10877)

Browse Source 
* Improved exceptions and unused method arguments which were disabled in linting

* Applied black to dashboard.py
This commit is contained in:
Kasia Kucharczyk 2020-09-15 17:26:04 +02:00 committed by GitHub
parent 38edb69d95
commit 2a6bcbb1eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
superset/models/dashboard.py
View File

@ -17,6 +17,7 @@
import json
import logging
from copy import copy
from json.decoder import JSONDecodeError
from typing import Any, Dict, List, Optional, Set, TYPE_CHECKING
from urllib import parse
@ -62,8 +63,9 @@ config = app.config
logger = logging.getLogger(__name__)
def copy_dashboard(mapper: Mapper, connection: Connection, target: "Dashboard") -> None:
# pylint: disable=unused-argument
def copy_dashboard(
_mapper: Mapper, connection: Connection, target: "Dashboard"
) -> None:
dashboard_id = config["DASHBOARD_TEMPLATE_ID"]
if dashboard_id is None:
return
@ -153,6 +155,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
@property
def url(self) -> str:
url = f"/superset/dashboard/{self.slug or self.id}/"
if self.json_metadata:
# add default_filters to the preselect_filters of dashboard
json_metadata = json.loads(self.json_metadata)
@ -165,9 +168,14 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
return "/superset/dashboard/{}/?preselect_filters={}".format(
self.slug or self.id, filters
)
except Exception: # pylint: disable=broad-except
pass
return f"/superset/dashboard/{self.slug or self.id}/"
except (TypeError, JSONDecodeError) as exc:
logger.error(
"Unable to parse json for url: %r. Returning default url.",
exc,
exc_info=True,
)
return url
return url
@property
def datasources(self) -> Set[Optional["BaseDatasource"]]:
@ -478,8 +486,8 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
)
def event_after_dashboard_changed( # pylint: disable=unused-argument
mapper: Mapper, connection: Connection, target: Dashboard
def event_after_dashboard_changed(
_mapper: Mapper, _connection: Connection, target: Dashboard
) -> None:
url = get_url_path("Superset.dashboard", dashboard_id_or_slug=target.id)
cache_dashboard_thumbnail.delay(url, target.digest, force=True)