pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Cleanup table access check naming (#27772)

This commit is contained in:
John Bodley 2024-04-03 16:02:00 -07:00 committed by GitHub
parent 5beda309ab
commit 27acc0b133
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
superset/databases/api.py
View File

@ -63,7 +63,7 @@ from superset.commands.importers.exceptions import (
from superset.commands.importers.v1.utils import get_contents_from_bundle
from superset.constants import MODEL_API_RW_METHOD_PERMISSION_MAP, RouteMethod
from superset.daos.database import DatabaseDAO, DatabaseUserOAuth2TokensDAO
from superset.databases.decorators import check_datasource_access
from superset.databases.decorators import check_table_access
from superset.databases.filters import DatabaseFilter, DatabaseUploadEnabledFilter
from superset.databases.schemas import (
database_schemas_query_schema,
@ -694,7 +694,7 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
@expose("/<int:pk>/table/<path:table_name>/<schema_name>/", methods=("GET",))
@protect()
@check_datasource_access
@check_table_access
@safe
@statsd_metrics
@event_logger.log_this_with_context(
@ -757,7 +757,7 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
@expose("/<int:pk>/table_extra/<path:table_name>/<schema_name>/", methods=("GET",))
@protect()
@check_datasource_access
@check_table_access
@safe
@statsd_metrics
@event_logger.log_this_with_context(
@ -820,7 +820,7 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
@expose("/<int:pk>/select_star/<path:table_name>/", methods=("GET",))
@expose("/<int:pk>/select_star/<path:table_name>/<schema_name>/", methods=("GET",))
@protect()
@check_datasource_access
@check_table_access
@safe
@statsd_metrics
@event_logger.log_this_with_context(

4
superset/databases/decorators.py
View File

@ -30,9 +30,9 @@ from superset.views.base_api import BaseSupersetModelRestApi
logger = logging.getLogger(__name__)
def check_datasource_access(f: Callable[..., Any]) -> Callable[..., Any]:
def check_table_access(f: Callable[..., Any]) -> Callable[..., Any]:
"""
A Decorator that checks if a user has datasource access
A Decorator that checks if a user has access to a table in a database.
"""
def wraps(