pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: handle null values in time-series table (#18039)

This commit is contained in:
Grace Guo 2022-01-13 21:47:07 -08:00 committed by GitHub
parent 343d3f8f7a
commit 26dc600aff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
superset-frontend/src/visualizations/TimeTable/TimeTable.jsx
View File

@ -192,14 +192,17 @@ const TimeTable = ({
} else { } else {
v = reversedEntries[timeLag][valueField]; v = reversedEntries[timeLag][valueField];
} }
if (column.comparisonType === 'diff') { if (typeof v === 'number' || typeof recent === 'number') {
v = recent - v; if (column.comparisonType === 'diff') {
} else if (column.comparisonType === 'perc') { v = recent - v;
v = recent / v; } else if (column.comparisonType === 'perc') {
} else if (column.comparisonType === 'perc_change') { v = recent / v;
v = recent / v - 1; } else if (column.comparisonType === 'perc_change') {
v = recent / v - 1;
}
} else {
v = 'N/A';
} }
v = v || 0;
} else if (column.colType === 'contrib') { } else if (column.colType === 'contrib') {
// contribution to column total // contribution to column total
v = v =