pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-07 06:17:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: customize tab on heatmap chart is blank (#23243)

Browse Source
This commit is contained in:
Lily Kuang 2023-03-01 14:02:12 -08:00 committed by GitHub
parent d3e698eb54
commit 1f3eb56688
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
superset-frontend/src/explore/components/ControlPanelsContainer.test.tsx
View File

@ -17,6 +17,7 @@
* under the License.
*/
import React from 'react';
import userEvent from '@testing-library/user-event';
import { render, screen } from 'spec/helpers/testing-library';
import {
DatasourceType,
@ -104,5 +105,43 @@ describe('ControlPanelsContainer', () => {
expect(
await screen.findAllByTestId('collapsible-control-panel-header'),
).toHaveLength(4);
expect(screen.getByRole('tab', { name: /customize/i })).toBeInTheDocument();
userEvent.click(screen.getByRole('tab', { name: /customize/i }));
expect(
await screen.findAllByTestId('collapsible-control-panel-header'),
).toHaveLength(5);
});
test('renders ControlPanelSections no Customize Tab', async () => {
getChartControlPanelRegistry().registerValue('table', {
controlPanelSections: [
{
label: t('GROUP BY'),
description: t(
'Use this section if you want a query that aggregates',
),
expanded: true,
controlSetRows: [
['groupby'],
['metrics'],
['percent_metrics'],
['timeseries_limit_metric', 'row_limit'],
['include_time', 'order_desc'],
],
},
{
label: t('Options'),
expanded: true,
controlSetRows: [],
},
],
});
render(<ControlPanelsContainer {...getDefaultProps()} />, {
useRedux: true,
});
expect(screen.queryByText(/customize/i)).not.toBeInTheDocument();
expect(
await screen.findAllByTestId('collapsible-control-panel-header'),
).toHaveLength(2);
});
});

2
superset-frontend/src/explore/components/ControlPanelsContainer.tsx
View File

@ -236,7 +236,7 @@ function getState(
)
) {
querySections.push(section);
} else {
} else if (section.controlSetRows.length > 0) {
customizeSections.push(section);
}
});