mirror of https://github.com/apache/superset.git
fix(dashboard): Change text and icons in dashboard editmode (#21305)
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io> Co-authored-by: geido <diegopucci.me@gmail.com>
This commit is contained in:
parent
389fa31b89
commit
1d70079f71
|
@ -243,17 +243,17 @@ describe('Dashboard edit', () => {
|
|||
.click();
|
||||
|
||||
// add new markdown component
|
||||
dragComponent('Markdown', 'new-component', false);
|
||||
dragComponent('Text', 'new-component', false);
|
||||
|
||||
cy.get('[data-test="dashboard-markdown-editor"]')
|
||||
cy.getBySel('dashboard-markdown-editor')
|
||||
.should(
|
||||
'have.text',
|
||||
'✨Markdown✨Markdown✨MarkdownClick here to edit markdown',
|
||||
'✨Header 1✨Header 2✨Header 3Click here to learn more about markdown formatting',
|
||||
)
|
||||
.click();
|
||||
.click(10, 10);
|
||||
|
||||
cy.getBySel('dashboard-component-chart-holder').contains(
|
||||
'Click here to edit [markdown](https://bit.ly/1dQOfRK)',
|
||||
'Click here to learn more about [markdown formatting](https://bit.ly/1dQOfRK)',
|
||||
);
|
||||
|
||||
cy.getBySel('dashboard-markdown-editor').click().type('Test resize');
|
||||
|
|
|
@ -69,13 +69,13 @@ const propTypes = {
|
|||
|
||||
const defaultProps = {};
|
||||
|
||||
const MARKDOWN_PLACE_HOLDER = `# ✨Markdown
|
||||
## ✨Markdown
|
||||
### ✨Markdown
|
||||
const MARKDOWN_PLACE_HOLDER = `# ✨Header 1
|
||||
## ✨Header 2
|
||||
### ✨Header 3
|
||||
|
||||
<br />
|
||||
|
||||
Click here to edit [markdown](https://bit.ly/1dQOfRK)`;
|
||||
Click here to learn more about [markdown formatting](https://bit.ly/1dQOfRK)`;
|
||||
|
||||
const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.');
|
||||
|
||||
|
|
|
@ -27,8 +27,8 @@ export default function DraggableNewDivider() {
|
|||
<DraggableNewComponent
|
||||
id={NEW_MARKDOWN_ID}
|
||||
type={MARKDOWN_TYPE}
|
||||
label="Markdown"
|
||||
className="fa fa-code"
|
||||
label="Text"
|
||||
className="fa fa-font"
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue