pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 22:07:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): Change text and icons in dashboard editmode (#21305)

Browse Source 
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
Co-authored-by: geido <diegopucci.me@gmail.com>
This commit is contained in:
Anthony Gainor 2022-09-30 08:36:11 -06:00 committed by GitHub
parent 389fa31b89
commit 1d70079f71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
View File

@ -243,17 +243,17 @@ describe('Dashboard edit', () => {
.click(); .click();
// add new markdown component // add new markdown component
dragComponent('Markdown', 'new-component', false); dragComponent('Text', 'new-component', false);
cy.get('[data-test="dashboard-markdown-editor"]') cy.getBySel('dashboard-markdown-editor')
.should( .should(
'have.text', 'have.text',
'✨Markdown✨Markdown✨MarkdownClick here to edit markdown', '✨Header 1✨Header 2✨Header 3Click here to learn more about markdown formatting',
) )
.click(); .click(10, 10);
cy.getBySel('dashboard-component-chart-holder').contains( cy.getBySel('dashboard-component-chart-holder').contains(
'Click here to edit [markdown](https://bit.ly/1dQOfRK)', 'Click here to learn more about [markdown formatting](https://bit.ly/1dQOfRK)',
); );
cy.getBySel('dashboard-markdown-editor').click().type('Test resize'); cy.getBySel('dashboard-markdown-editor').click().type('Test resize');

8
superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
View File

@ -69,13 +69,13 @@ const propTypes = {
const defaultProps = {}; const defaultProps = {};
const MARKDOWN_PLACE_HOLDER = `# ✨Markdown const MARKDOWN_PLACE_HOLDER = `# ✨Header 1
## ✨Markdown ## ✨Header 2
### ✨Markdown ### ✨Header 3
<br /> <br />
Click here to edit [markdown](https://bit.ly/1dQOfRK)`; Click here to learn more about [markdown formatting](https://bit.ly/1dQOfRK)`;
const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.'); const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.');

4
superset-frontend/src/dashboard/components/gridComponents/new/NewMarkdown.jsx
View File

@ -27,8 +27,8 @@ export default function DraggableNewDivider() {
<DraggableNewComponent <DraggableNewComponent
id={NEW_MARKDOWN_ID} id={NEW_MARKDOWN_ID}
type={MARKDOWN_TYPE} type={MARKDOWN_TYPE}
label="Markdown" label="Text"
className="fa fa-code" className="fa fa-font"
/> />
); );
} }