pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 00:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use connector registry for metrics (#2420)

Browse Source
This commit is contained in:
Bogdan 2017-03-15 18:13:15 -07:00 committed by GitHub
parent 696678c981
commit 1b330a8c55
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
superset/views/core.py
View File

@ -1794,6 +1794,7 @@ class Superset(BaseSupersetView):
is_dim = config.get('is_dim', False)
SqlaTable = ConnectorRegistry.sources['table']
TableColumn = SqlaTable.column_cls
SqlMetric = SqlaTable.metric_cls
col = TableColumn(
column_name=column_name,
filterable=is_dim,
@ -1806,18 +1807,18 @@ class Superset(BaseSupersetView):
agg = config.get('agg')
if agg:
if agg == 'count_distinct':
metrics.append(models.SqlMetric(
metrics.append(SqlMetric(
metric_name="{agg}__{column_name}".format(**locals()),
expression="COUNT(DISTINCT {column_name})"
.format(**locals()),
))
else:
metrics.append(models.SqlMetric(
metrics.append(SqlMetric(
metric_name="{agg}__{column_name}".format(**locals()),
expression="{agg}({column_name})".format(**locals()),
))
if not metrics:
metrics.append(models.SqlMetric(
metrics.append(SqlMetric(
metric_name="count".format(**locals()),
expression="count(*)".format(**locals()),
))