fix(explore): Value undefined and Unhashable type errors (#22207)

This commit is contained in:
Kamil Gabryjelski 2022-11-23 20:45:10 +01:00 committed by GitHub
parent 888f43c6ad
commit 1809d2b957
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -37,6 +37,7 @@ import {
SupersetTheme, SupersetTheme,
useTheme, useTheme,
isDefined, isDefined,
JsonValue,
} from '@superset-ui/core'; } from '@superset-ui/core';
import { import {
ControlPanelSectionConfig, ControlPanelSectionConfig,
@ -276,21 +277,36 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
>(state => state.explore.controlsTransferred); >(state => state.explore.controlsTransferred);
useEffect(() => { useEffect(() => {
const removeDatasourceWarningFromControl = (
value: JsonValue | undefined,
) => {
if (
typeof value === 'object' &&
isDefined(value) &&
'datasourceWarning' in value
) {
return { ...value, datasourceWarning: false };
}
return value;
};
if (props.chart.chartStatus === 'success') { if (props.chart.chartStatus === 'success') {
controlsTransferred?.forEach(controlName => { controlsTransferred?.forEach(controlName => {
const alteredControls = ensureIsArray( if (!isDefined(props.controls[controlName])) {
props.controls[controlName].value, return;
).map(value => { }
if ( if (Array.isArray(props.controls[controlName].value)) {
typeof value === 'object' && const alteredControls = ensureIsArray(
isDefined(value) && props.controls[controlName].value,
'datasourceWarning' in value )?.map(removeDatasourceWarningFromControl);
) { props.actions.setControlValue(controlName, alteredControls);
return { ...value, datasourceWarning: false }; } else {
} props.actions.setControlValue(
return value; controlName,
}); removeDatasourceWarningFromControl(
props.actions.setControlValue(controlName, alteredControls); props.controls[controlName].value,
),
);
}
}); });
} }
}, [ }, [