pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: New time range filter initially show advance section (#15889)

This commit is contained in:
Michael S. Molina 2021-07-26 15:14:43 -03:00 committed by GitHub
parent fb5dce07b7
commit 16a26bac35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
View File

@ -585,6 +585,10 @@ const FiltersConfigForm = (
const defaultToFirstItem = formFilter?.controlValues?.defaultToFirstItem;
const hasAdvancedSection =
formFilter?.filterType === 'filter_select' ||
formFilter?.filterType === 'filter_range';
const preFilterValidator = () => {
if (hasTimeRange || hasAdhoc) {
return Promise.resolve();
@ -847,7 +851,7 @@ const FiltersConfigForm = (
.filter(key => BASIC_CONTROL_ITEMS.includes(key))
.map(key => controlItems[key].element)}
</Collapse.Panel>
{((hasDataset && hasAdditionalFilters) || hasMetrics) && (
{hasAdvancedSection && (
<Collapse.Panel
forceRender
header={FilterPanels.advanced.name}