mirror of https://github.com/apache/superset.git
fix(explore): restored hidden field values has discarded (#29349)
This commit is contained in:
parent
ee5227733b
commit
160cece017
|
@ -231,9 +231,7 @@ describe('reducers', () => {
|
||||||
newState,
|
newState,
|
||||||
actions.setStashFormData(false, ['y_axis_format']),
|
actions.setStashFormData(false, ['y_axis_format']),
|
||||||
);
|
);
|
||||||
expect(updatedState.hiddenFormData).toEqual({
|
expect(updatedState.hiddenFormData.y_axis_format).toBeFalsy();
|
||||||
y_axis_format: defaultState.form_data.y_axis_format,
|
|
||||||
});
|
|
||||||
expect(updatedState.form_data.y_axis_format).toEqual(
|
expect(updatedState.form_data.y_axis_format).toEqual(
|
||||||
defaultState.form_data.y_axis_format,
|
defaultState.form_data.y_axis_format,
|
||||||
);
|
);
|
||||||
|
|
|
@ -267,7 +267,7 @@ export default function exploreReducer(state = {}, action) {
|
||||||
...form_data,
|
...form_data,
|
||||||
...restoredField,
|
...restoredField,
|
||||||
},
|
},
|
||||||
hiddenFormData,
|
hiddenFormData: omit(hiddenFormData, fieldNames),
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
[actions.SLICE_UPDATED]() {
|
[actions.SLICE_UPDATED]() {
|
||||||
|
|
|
@ -0,0 +1,35 @@
|
||||||
|
/**
|
||||||
|
* Licensed to the Apache Software Foundation (ASF) under one
|
||||||
|
* or more contributor license agreements. See the NOTICE file
|
||||||
|
* distributed with this work for additional information
|
||||||
|
* regarding copyright ownership. The ASF licenses this file
|
||||||
|
* to you under the Apache License, Version 2.0 (the
|
||||||
|
* "License"); you may not use this file except in compliance
|
||||||
|
* with the License. You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing,
|
||||||
|
* software distributed under the License is distributed on an
|
||||||
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||||
|
* KIND, either express or implied. See the License for the
|
||||||
|
* specific language governing permissions and limitations
|
||||||
|
* under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import exploreReducer from './exploreReducer';
|
||||||
|
import { setStashFormData } from '../actions/exploreActions';
|
||||||
|
|
||||||
|
test('reset hiddenFormData on SET_STASH_FORM_DATA', () => {
|
||||||
|
const initialState = {
|
||||||
|
form_data: { a: 3, c: 4 },
|
||||||
|
};
|
||||||
|
const action = setStashFormData(true, ['a', 'c']);
|
||||||
|
const newState = exploreReducer(initialState, action);
|
||||||
|
expect(newState.form_data).toEqual({});
|
||||||
|
expect(newState.hiddenFormData).toEqual({ a: 3, c: 4 });
|
||||||
|
const restoreAction = setStashFormData(false, ['c']);
|
||||||
|
const newState2 = exploreReducer(newState, restoreAction);
|
||||||
|
expect(newState2.form_data).toEqual({ c: 4 });
|
||||||
|
expect(newState2.hiddenFormData).toEqual({ a: 3 });
|
||||||
|
});
|
Loading…
Reference in New Issue