pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-07 06:17:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): JS error when editing charts (#21422)

Browse Source
This commit is contained in:
Jesse Yang 2022-09-12 07:43:48 -07:00 committed by GitHub
parent d28909d56c
commit 1084bde2cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
superset-frontend/src/explore/ExplorePage.tsx
View File

@ -61,11 +61,20 @@ const fetchExploreData = async (exploreUrlParams: URLSearchParams) => {
} }
}; };
const getDashboardPageContext = (pageId?: string | null) => {
if (!pageId) {
return null;
}
return (
getItem(LocalStorageKeys.dashboard__explore_context, {})[pageId] || null
);
};
const getDashboardContextFormData = () => { const getDashboardContextFormData = () => {
const dashboardPageId = getUrlParam(URL_PARAMS.dashboardPageId); const dashboardPageId = getUrlParam(URL_PARAMS.dashboardPageId);
const sliceId = getUrlParam(URL_PARAMS.sliceId) || 0; const dashboardContext = getDashboardPageContext(dashboardPageId);
let dashboardContextWithFilters = {}; if (dashboardContext) {
if (dashboardPageId) { const sliceId = getUrlParam(URL_PARAMS.sliceId) || 0;
const { const {
labelColors, labelColors,
sharedLabelColors, sharedLabelColors,
@ -75,11 +84,8 @@ const getDashboardContextFormData = () => {
filterBoxFilters, filterBoxFilters,
dataMask, dataMask,
dashboardId, dashboardId,
} = } = dashboardContext;
getItem(LocalStorageKeys.dashboard__explore_context, {})[ const dashboardContextWithFilters = getFormDataWithExtraFilters({
dashboardPageId
] || {};
dashboardContextWithFilters = getFormDataWithExtraFilters({
chart: { id: sliceId }, chart: { id: sliceId },
filters: getAppliedFilterValues(sliceId, filterBoxFilters), filters: getAppliedFilterValues(sliceId, filterBoxFilters),
nativeFilters, nativeFilters,